-
Notifications
You must be signed in to change notification settings - Fork 996
/
Copy pathtest_views.py
4390 lines (3881 loc) · 166 KB
/
test_views.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import datetime
import json
import uuid
from datetime import timedelta
import freezegun
import pretend
import pytest
import pytz
from pyramid.httpexceptions import (
HTTPBadRequest,
HTTPMovedPermanently,
HTTPNotFound,
HTTPSeeOther,
HTTPTooManyRequests,
HTTPUnauthorized,
)
from sqlalchemy.exc import NoResultFound
from webauthn.authentication.verify_authentication_response import (
VerifiedAuthentication,
)
from webob.multidict import MultiDict
from warehouse.accounts import views
from warehouse.accounts.interfaces import (
IPasswordBreachedService,
ITokenService,
IUserService,
TokenException,
TokenExpired,
TokenInvalid,
TokenMissing,
TooManyEmailsAdded,
TooManyFailedLogins,
TooManyPasswordResetRequests,
)
from warehouse.accounts.views import (
REMEMBER_DEVICE_COOKIE,
two_factor_and_totp_validate,
)
from warehouse.admin.flags import AdminFlag, AdminFlagValue
from warehouse.captcha.interfaces import ICaptchaService
from warehouse.events.tags import EventTag
from warehouse.metrics.interfaces import IMetricsService
from warehouse.oidc.interfaces import TooManyOIDCRegistrations
from warehouse.oidc.models import PendingGitHubPublisher, PendingGooglePublisher
from warehouse.organizations.models import (
OrganizationInvitation,
OrganizationRole,
OrganizationRoleType,
)
from warehouse.packaging.models import Role, RoleInvitation
from warehouse.rate_limiting.interfaces import IRateLimiter
from ...common.db.accounts import EmailFactory, UserFactory
from ...common.db.ip_addresses import IpAddressFactory
from ...common.db.organizations import (
OrganizationFactory,
OrganizationInvitationFactory,
OrganizationRoleFactory,
)
from ...common.db.packaging import ProjectFactory, RoleFactory, RoleInvitationFactory
class TestFailedLoginView:
def test_too_many_failed_logins(self, pyramid_request):
exc = TooManyFailedLogins(resets_in=datetime.timedelta(seconds=600))
resp = views.failed_logins(exc, pyramid_request)
assert resp.status == "429 Too Many Failed Login Attempts"
assert resp.detail == (
"There have been too many unsuccessful login attempts. "
"You have been locked out for 10 minutes. "
"Please try again later."
)
assert dict(resp.headers).get("Retry-After") == "600"
def test_too_many_emails_added(self, pyramid_request):
exc = TooManyEmailsAdded(resets_in=datetime.timedelta(seconds=600))
resp = views.unverified_emails(exc, pyramid_request)
assert resp.status == "429 Too Many Requests"
assert resp.detail == (
"Too many emails have been added to this account without verifying "
"them. Check your inbox and follow the verification links. (IP: "
f"{ pyramid_request.remote_addr })"
)
assert dict(resp.headers).get("Retry-After") == "600"
def test_too_many_password_reset_requests(self, pyramid_request):
exc = TooManyPasswordResetRequests(resets_in=datetime.timedelta(seconds=600))
resp = views.incomplete_password_resets(exc, pyramid_request)
assert resp.status == "429 Too Many Requests"
assert resp.detail == (
"Too many password resets have been requested for this account without "
"completing them. Check your inbox and follow the verification links. (IP: "
f"{ pyramid_request.remote_addr })"
)
assert dict(resp.headers).get("Retry-After") == "600"
class TestUserProfile:
def test_user_redirects_username(self, db_request):
user = UserFactory.create()
if user.username.upper() != user.username:
username = user.username.upper()
else:
username = user.username.lower()
db_request.current_route_path = pretend.call_recorder(
lambda username: "/user/the-redirect/"
)
db_request.matchdict = {"username": username}
result = views.profile(user, db_request)
assert isinstance(result, HTTPMovedPermanently)
assert result.headers["Location"] == "/user/the-redirect/"
assert db_request.current_route_path.calls == [
pretend.call(username=user.username)
]
def test_returns_user(self, db_request):
user = UserFactory.create()
assert views.profile(user, db_request) == {"user": user, "projects": []}
class TestAccountsSearch:
def test_unauthenticated_raises_401(self):
pyramid_request = pretend.stub(user=None)
with pytest.raises(HTTPUnauthorized):
views.accounts_search(pyramid_request)
def test_no_query_string_raises_400(self):
pyramid_request = pretend.stub(user=pretend.stub(), params=MultiDict({}))
with pytest.raises(HTTPBadRequest):
views.accounts_search(pyramid_request)
def test_returns_users_with_prefix(self, db_session, user_service):
foo = UserFactory.create(username="foo")
bas = [
UserFactory.create(username="bar"),
UserFactory.create(username="baz"),
]
request = pretend.stub(
user=pretend.stub(),
find_service=lambda svc, **kw: {
IUserService: user_service,
IRateLimiter: pretend.stub(
test=pretend.call_recorder(lambda ip_address: True),
hit=pretend.call_recorder(lambda ip_address: None),
),
}[svc],
ip_address=IpAddressFactory.build(),
)
request.params = MultiDict({"username": "f"})
result = views.accounts_search(request)
assert result == {"users": [foo]}
request.params = MultiDict({"username": "ba"})
result = views.accounts_search(request)
assert result == {"users": bas}
request.params = MultiDict({"username": "zzz"})
with pytest.raises(HTTPNotFound):
views.accounts_search(request)
def test_when_rate_limited(self, db_session):
search_limiter = pretend.stub(
test=pretend.call_recorder(lambda ip_address: False),
)
request = pretend.stub(
user=pretend.stub(),
find_service=lambda svc, **kw: {
IRateLimiter: search_limiter,
}[svc],
ip_address=IpAddressFactory.build(),
)
request.params = MultiDict({"username": "foo"})
result = views.accounts_search(request)
assert search_limiter.test.calls == [pretend.call(request.ip_address)]
assert result == {"users": []}
class TestLogin:
@pytest.mark.parametrize("next_url", [None, "/foo/bar/", "/wat/"])
def test_get_returns_form(self, pyramid_request, pyramid_services, next_url):
user_service = pretend.stub()
breach_service = pretend.stub()
pyramid_services.register_service(user_service, IUserService, None)
pyramid_services.register_service(
breach_service, IPasswordBreachedService, None
)
form_obj = pretend.stub()
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
if next_url is not None:
pyramid_request.GET["next"] = next_url
result = views.login(pyramid_request, _form_class=form_class)
assert result == {
"form": form_obj,
"redirect": {"field": "next", "data": next_url},
}
assert form_class.calls == [
pretend.call(
pyramid_request.POST,
request=pyramid_request,
user_service=user_service,
breach_service=breach_service,
check_password_metrics_tags=["method:auth", "auth_method:login_form"],
)
]
@pytest.mark.parametrize("next_url", [None, "/foo/bar/", "/wat/"])
def test_post_invalid_returns_form(
self, pyramid_request, pyramid_services, metrics, next_url
):
user_service = pretend.stub()
breach_service = pretend.stub()
pyramid_services.register_service(user_service, IUserService, None)
pyramid_services.register_service(
breach_service, IPasswordBreachedService, None
)
pyramid_request.method = "POST"
if next_url is not None:
pyramid_request.POST["next"] = next_url
form_obj = pretend.stub(validate=pretend.call_recorder(lambda: False))
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
result = views.login(pyramid_request, _form_class=form_class)
assert metrics.increment.calls == []
assert result == {
"form": form_obj,
"redirect": {"field": "next", "data": next_url},
}
assert form_class.calls == [
pretend.call(
pyramid_request.POST,
request=pyramid_request,
user_service=user_service,
breach_service=breach_service,
check_password_metrics_tags=["method:auth", "auth_method:login_form"],
)
]
assert form_obj.validate.calls == [pretend.call()]
@pytest.mark.parametrize("with_user", [True, False])
def test_post_validate_redirects(
self, monkeypatch, pyramid_request, pyramid_services, metrics, with_user
):
remember = pretend.call_recorder(lambda request, user_id: [("foo", "bar")])
monkeypatch.setattr(views, "remember", remember)
new_session = {}
user_id = uuid.uuid4()
user = pretend.stub(
record_event=pretend.call_recorder(lambda *a, **kw: None),
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: user_id),
update_user=pretend.call_recorder(lambda *a, **kw: None),
get_user=pretend.call_recorder(lambda userid: user),
has_two_factor=lambda userid: False,
get_password_timestamp=lambda userid: 0,
)
breach_service = pretend.stub(check_password=lambda password, tags=None: False)
pyramid_services.register_service(user_service, IUserService, None)
pyramid_services.register_service(
breach_service, IPasswordBreachedService, None
)
pyramid_request.method = "POST"
pyramid_request.session = pretend.stub(
items=lambda: [("a", "b"), ("foo", "bar")],
update=new_session.update,
invalidate=pretend.call_recorder(lambda: None),
new_csrf_token=pretend.call_recorder(lambda: None),
)
pyramid_request._unauthenticated_userid = (
str(uuid.uuid4()) if with_user else None
)
pyramid_request.registry.settings = {"sessions.secret": "dummy_secret"}
pyramid_request.session.record_auth_timestamp = pretend.call_recorder(
lambda *args: None
)
pyramid_request.session.record_password_timestamp = lambda timestamp: None
form_obj = pretend.stub(
validate=pretend.call_recorder(lambda: True),
username=pretend.stub(data="theuser"),
password=pretend.stub(data="password"),
)
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
pyramid_request.route_path = pretend.call_recorder(lambda a: "/the-redirect")
now = datetime.datetime.utcnow()
with freezegun.freeze_time(now):
result = views.login(pyramid_request, _form_class=form_class)
assert metrics.increment.calls == []
assert isinstance(result, HTTPSeeOther)
assert pyramid_request.route_path.calls == [pretend.call("manage.projects")]
assert result.headers["Location"] == "/the-redirect"
assert result.headers["foo"] == "bar"
assert form_class.calls == [
pretend.call(
pyramid_request.POST,
request=pyramid_request,
user_service=user_service,
breach_service=breach_service,
check_password_metrics_tags=["method:auth", "auth_method:login_form"],
)
]
assert form_obj.validate.calls == [pretend.call()]
assert user_service.find_userid.calls == [pretend.call("theuser")]
assert user_service.update_user.calls == [pretend.call(user_id, last_login=now)]
assert user.record_event.calls == [
pretend.call(
tag=EventTag.Account.LoginSuccess,
request=pyramid_request,
additional={"two_factor_method": None, "two_factor_label": None},
)
]
if with_user:
assert new_session == {}
else:
assert new_session == {"a": "b", "foo": "bar"}
assert remember.calls == [pretend.call(pyramid_request, str(user_id))]
assert pyramid_request.session.invalidate.calls == [pretend.call()]
assert pyramid_request.session.new_csrf_token.calls == [pretend.call()]
assert pyramid_request.session.record_auth_timestamp.calls == [pretend.call()]
@pytest.mark.parametrize(
# The set of all possible next URLs. Since this set is infinite, we
# test only a finite set of reasonable URLs.
("expected_next_url, observed_next_url"),
[("/security/", "/security/"), ("http://example.com", "/the-redirect")],
)
def test_post_validate_no_redirects(
self, pyramid_request, pyramid_services, expected_next_url, observed_next_url
):
user = pretend.stub(
record_event=pretend.call_recorder(lambda *a, **kw: None),
)
user_service = pretend.stub(
get_user=pretend.call_recorder(lambda userid: user),
find_userid=pretend.call_recorder(lambda username: 1),
update_user=lambda *a, **k: None,
has_two_factor=lambda userid: False,
get_password_timestamp=lambda userid: 0,
)
breach_service = pretend.stub(check_password=lambda password, tags=None: False)
pyramid_services.register_service(user_service, IUserService, None)
pyramid_services.register_service(
breach_service, IPasswordBreachedService, None
)
pyramid_request.method = "POST"
pyramid_request.POST["next"] = expected_next_url
pyramid_request.session.record_auth_timestamp = pretend.call_recorder(
lambda *args: None
)
pyramid_request.session.record_password_timestamp = lambda timestamp: None
security_policy = pretend.stub(
identity=lambda r: None,
remember=lambda r, u, **kw: [],
reset=pretend.call_recorder(lambda r: None),
)
pyramid_request.registry.queryUtility = lambda iface: security_policy
form_obj = pretend.stub(
validate=pretend.call_recorder(lambda: True),
username=pretend.stub(data="theuser"),
password=pretend.stub(data="password"),
)
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
pyramid_request.route_path = pretend.call_recorder(lambda a: "/the-redirect")
result = views.login(pyramid_request, _form_class=form_class)
assert isinstance(result, HTTPSeeOther)
assert result.headers["Location"] == observed_next_url
assert user.record_event.calls == [
pretend.call(
tag=EventTag.Account.LoginSuccess,
request=pyramid_request,
additional={"two_factor_method": None, "two_factor_label": None},
)
]
assert pyramid_request.session.record_auth_timestamp.calls == [pretend.call()]
assert security_policy.reset.calls == [pretend.call(pyramid_request)]
def test_redirect_authenticated_user(self):
pyramid_request = pretend.stub(user=pretend.stub())
pyramid_request.route_path = pretend.call_recorder(lambda a: "/the-redirect")
result = views.login(pyramid_request)
assert isinstance(result, HTTPSeeOther)
assert result.headers["Location"] == "/the-redirect"
@pytest.mark.parametrize("redirect_url", ["test_redirect_url", None])
def test_two_factor_auth(
self, monkeypatch, pyramid_request, redirect_url, token_service
):
token_service.dumps = lambda d: "fake_token"
monkeypatch.setattr(
views, "_check_remember_device_token", lambda *a, **kw: False
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: 1),
update_user=lambda *a, **k: None,
has_two_factor=lambda userid: True,
record_event=pretend.call_recorder(lambda *a, **kw: None),
)
breach_service = pretend.stub(check_password=lambda pw: False)
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
IPasswordBreachedService: breach_service,
}[interface]
pyramid_request.method = "POST"
if redirect_url:
pyramid_request.POST["next"] = redirect_url
form_obj = pretend.stub(
validate=pretend.call_recorder(lambda: True),
username=pretend.stub(data="theuser"),
)
form_class = pretend.call_recorder(lambda d, user_service, **kw: form_obj)
pyramid_request.route_path = pretend.call_recorder(
lambda a, **kw: "/account/two-factor"
)
pyramid_request.params = pretend.stub(
get=pretend.call_recorder(lambda k: {"userid": 1}[k])
)
result = views.login(pyramid_request, _form_class=form_class)
token_expected_data = {"userid": 1}
if redirect_url:
token_expected_data["redirect_to"] = redirect_url
assert isinstance(result, HTTPSeeOther)
assert result.headerlist == [
("Content-Type", "text/html; charset=UTF-8"),
("Content-Length", "0"),
("Location", "/account/two-factor"),
]
class TestTwoFactor:
def test_get_two_factor_data_invalid_after_login(self, pyramid_request):
sign_time = datetime.datetime.utcnow() - datetime.timedelta(seconds=30)
last_login_time = datetime.datetime.utcnow() - datetime.timedelta(seconds=1)
query_params = {"userid": 1}
token_service = pretend.stub(
loads=pretend.call_recorder(
lambda *args, **kwargs: (query_params, sign_time)
)
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: 1),
get_user=pretend.call_recorder(
lambda userid: pretend.stub(last_login=last_login_time)
),
update_user=lambda *a, **k: None,
has_totp=lambda uid: True,
has_webauthn=lambda uid: False,
has_recovery_codes=lambda uid: False,
)
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface]
pyramid_request.query_string = pretend.stub()
with pytest.raises(TokenInvalid):
views._get_two_factor_data(pyramid_request)
def test_two_factor_and_totp_validate_redirect_to_account_login(
self,
db_request,
token_service,
user_service,
):
"""
Checks redirect to the login page if the 2fa login got expired.
Given there's user in the database and has a token signed before last_login date
When the user calls accounts.two-factor view
Then the user is redirected to account/login page
... warning::
This test has to use database and load the user from database
to make sure we always compare user.last_login as timezone-aware datetime.
"""
user = UserFactory.create(
username="jdoe",
name="Joe",
password="any",
is_active=True,
last_login=datetime.datetime.utcnow() + datetime.timedelta(days=+1),
)
token_data = {"userid": user.id}
# Remove user object from scope, The `token_service` will load the user
# from the `user_service` and handle it from there
db_request.db.expunge(user)
del user
token = token_service.dumps(token_data)
db_request.query_string = token
db_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface]
db_request.route_path = pretend.call_recorder(lambda name: "/account/login/")
two_factor_and_totp_validate(db_request)
# This view is redirected to only during a TokenException recovery
# which is called in two instances:
# 1. No userid in token
# 2. The token has expired
assert db_request.route_path.calls == [pretend.call("accounts.login")]
@pytest.mark.parametrize("redirect_url", [None, "/foo/bar/", "/wat/"])
def test_get_returns_totp_form(self, pyramid_request, redirect_url):
query_params = {"userid": 1}
if redirect_url:
query_params["redirect_to"] = redirect_url
token_service = pretend.stub(
loads=pretend.call_recorder(
lambda *args, **kwargs: (query_params, datetime.datetime.utcnow())
)
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: 1),
get_user=pretend.call_recorder(
lambda userid: pretend.stub(
last_login=(datetime.datetime.utcnow() - datetime.timedelta(days=1))
)
),
update_user=lambda *a, **k: None,
has_totp=lambda uid: True,
has_webauthn=lambda uid: False,
has_recovery_codes=lambda uid: False,
)
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface]
pyramid_request.registry.settings = {"remember_device.days": 30}
pyramid_request.query_string = pretend.stub()
form_obj = pretend.stub()
form_class = pretend.call_recorder(lambda d, user_service, **kw: form_obj)
result = views.two_factor_and_totp_validate(
pyramid_request, _form_class=form_class
)
assert token_service.loads.calls == [
pretend.call(pyramid_request.query_string, return_timestamp=True)
]
assert result == {"totp_form": form_obj, "remember_device_days": 30}
assert form_class.calls == [
pretend.call(
pyramid_request.POST,
request=pyramid_request,
user_id=1,
user_service=user_service,
check_password_metrics_tags=["method:auth", "auth_method:login_form"],
)
]
@pytest.mark.parametrize("redirect_url", [None, "/foo/bar/", "/wat/"])
def test_get_returns_webauthn(self, pyramid_request, redirect_url):
query_params = {"userid": 1}
if redirect_url:
query_params["redirect_to"] = redirect_url
token_service = pretend.stub(
loads=pretend.call_recorder(
lambda *args, **kwargs: (query_params, datetime.datetime.utcnow())
)
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: 1),
get_user=pretend.call_recorder(
lambda userid: pretend.stub(
last_login=(datetime.datetime.utcnow() - datetime.timedelta(days=1))
)
),
update_user=lambda *a, **k: None,
has_totp=lambda uid: False,
has_webauthn=lambda uid: True,
has_recovery_codes=lambda uid: False,
)
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface]
pyramid_request.registry.settings = {"remember_device.days": 30}
pyramid_request.query_string = pretend.stub()
result = views.two_factor_and_totp_validate(
pyramid_request, _form_class=pretend.stub()
)
assert token_service.loads.calls == [
pretend.call(pyramid_request.query_string, return_timestamp=True)
]
assert result == {"has_webauthn": True, "remember_device_days": 30}
@pytest.mark.parametrize("redirect_url", [None, "/foo/bar/", "/wat/"])
def test_get_returns_recovery_code_status(self, pyramid_request, redirect_url):
query_params = {"userid": 1}
if redirect_url:
query_params["redirect_to"] = redirect_url
token_service = pretend.stub(
loads=pretend.call_recorder(
lambda *args, **kwargs: (query_params, datetime.datetime.utcnow())
)
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: 1),
get_user=pretend.call_recorder(
lambda userid: pretend.stub(
last_login=(datetime.datetime.utcnow() - datetime.timedelta(days=1))
)
),
update_user=lambda *a, **k: None,
has_totp=lambda uid: False,
has_webauthn=lambda uid: False,
has_recovery_codes=lambda uid: True,
)
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface]
pyramid_request.registry.settings = {"remember_device.days": 30}
pyramid_request.query_string = pretend.stub()
result = views.two_factor_and_totp_validate(
pyramid_request, _form_class=pretend.stub()
)
assert token_service.loads.calls == [
pretend.call(pyramid_request.query_string, return_timestamp=True)
]
assert result == {"has_recovery_codes": True, "remember_device_days": 30}
@pytest.mark.parametrize("redirect_url", ["test_redirect_url", None])
@pytest.mark.parametrize("has_recovery_codes", [True, False])
@pytest.mark.parametrize("remember_device", [True, False])
def test_totp_auth(
self,
monkeypatch,
pyramid_request,
redirect_url,
has_recovery_codes,
remember_device,
):
remember = pretend.call_recorder(lambda request, user_id: [("foo", "bar")])
monkeypatch.setattr(views, "remember", remember)
_remember_device = pretend.call_recorder(lambda *a, **kw: None)
monkeypatch.setattr(views, "_remember_device", _remember_device)
query_params = {"userid": str(1)}
if redirect_url:
query_params["redirect_to"] = redirect_url
token_service = pretend.stub(
loads=pretend.call_recorder(
lambda *args, **kwargs: (query_params, datetime.datetime.utcnow())
)
)
user = pretend.stub(
last_login=(datetime.datetime.utcnow() - datetime.timedelta(days=1)),
has_recovery_codes=has_recovery_codes,
record_event=pretend.call_recorder(lambda *a, **kw: None),
)
user_service = pretend.stub(
find_userid=pretend.call_recorder(lambda username: 1),
get_user=pretend.call_recorder(lambda userid: user),
update_user=lambda *a, **k: None,
has_totp=lambda userid: True,
has_webauthn=lambda userid: False,
has_recovery_codes=lambda userid: has_recovery_codes,
check_totp_value=lambda userid, totp_value: True,
get_password_timestamp=lambda userid: 0,
)
new_session = {}
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface]
pyramid_request.method = "POST"
pyramid_request.session = pretend.stub(
items=lambda: [("a", "b"), ("foo", "bar")],
update=new_session.update,
invalidate=pretend.call_recorder(lambda: None),
new_csrf_token=pretend.call_recorder(lambda: None),
get_password_timestamp=lambda userid: 0,
)
pyramid_request.session.record_auth_timestamp = pretend.call_recorder(
lambda *args: None
)
pyramid_request.session.record_password_timestamp = lambda timestamp: None
pyramid_request.registry.settings = {"remember_device.days": 30}
form_obj = pretend.stub(
validate=pretend.call_recorder(lambda: True),
totp_value=pretend.stub(data="test-otp-secret"),
remember_device=pretend.stub(data=remember_device),
)
form_class = pretend.call_recorder(lambda d, user_service, **kw: form_obj)
pyramid_request.route_path = pretend.call_recorder(
lambda a: "/account/two-factor"
)
pyramid_request.params = pretend.stub(
get=pretend.call_recorder(lambda k: query_params.get(k))
)
pyramid_request.user = user
send_email = pretend.call_recorder(lambda *a: None)
monkeypatch.setattr(views, "send_recovery_code_reminder_email", send_email)
result = views.two_factor_and_totp_validate(
pyramid_request, _form_class=form_class
)
token_expected_data = {"userid": str(1)}
if redirect_url:
token_expected_data["redirect_to"] = redirect_url
assert isinstance(result, HTTPSeeOther)
assert remember.calls == [pretend.call(pyramid_request, str(1))]
assert pyramid_request.session.invalidate.calls == [pretend.call()]
assert pyramid_request.session.new_csrf_token.calls == [pretend.call()]
assert user.record_event.calls == [
pretend.call(
tag=EventTag.Account.LoginSuccess,
request=pyramid_request,
additional={"two_factor_method": "totp", "two_factor_label": "totp"},
)
]
assert pyramid_request.session.record_auth_timestamp.calls == [pretend.call()]
assert send_email.calls == (
[] if has_recovery_codes else [pretend.call(pyramid_request, user)]
)
assert _remember_device.calls == (
[]
if not remember_device
else [pretend.call(pyramid_request, result, str(1), "totp")]
)
def test_totp_auth_already_authed(self):
request = pretend.stub(
identity=pretend.stub(),
route_path=pretend.call_recorder(lambda p: "redirect_to"),
)
result = views.two_factor_and_totp_validate(request)
assert request.route_path.calls == [pretend.call("manage.projects")]
assert isinstance(result, HTTPSeeOther)
assert result.headers["Location"] == "redirect_to"
def test_totp_form_invalid(self):
token_data = {"userid": 1}
token_service = pretend.stub(
loads=pretend.call_recorder(
lambda *args, **kwargs: (token_data, datetime.datetime.utcnow())
)
)
user_service = pretend.stub(
get_user=pretend.call_recorder(
lambda userid: pretend.stub(
last_login=(datetime.datetime.utcnow() - datetime.timedelta(days=1))
)
),
has_totp=lambda userid: True,
has_webauthn=lambda userid: False,
has_recovery_codes=lambda userid: False,
check_totp_value=lambda userid, totp_value: False,
)
request = pretend.stub(
POST={},
method="POST",
session=pretend.stub(flash=pretend.call_recorder(lambda *a, **kw: None)),
identity=None,
route_path=pretend.call_recorder(lambda p: "redirect_to"),
find_service=lambda interface, **kwargs: {
ITokenService: token_service,
IUserService: user_service,
}[interface],
query_string=pretend.stub(),
registry=pretend.stub(settings={"remember_device.days": 30}),
)
form_obj = pretend.stub(
validate=pretend.call_recorder(lambda: False),
totp_value=pretend.stub(data="test-otp-secret"),
)
form_class = pretend.call_recorder(lambda *a, **kw: form_obj)
result = views.two_factor_and_totp_validate(request, _form_class=form_class)
assert token_service.loads.calls == [
pretend.call(request.query_string, return_timestamp=True)
]
assert result == {"totp_form": form_obj, "remember_device_days": 30}
def test_two_factor_token_missing_userid(self, pyramid_request):
token_service = pretend.stub(
loads=pretend.call_recorder(lambda *a, **kw: ({}, None))
)
pyramid_request.session = pretend.stub(
flash=pretend.call_recorder(lambda *a, **kw: None)
)
pyramid_request.route_path = pretend.call_recorder(lambda p: "redirect_to")
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service
}[interface]
pyramid_request.query_string = pretend.stub()
result = views.two_factor_and_totp_validate(pyramid_request)
assert token_service.loads.calls == [
pretend.call(pyramid_request.query_string, return_timestamp=True)
]
assert pyramid_request.route_path.calls == [pretend.call("accounts.login")]
assert pyramid_request.session.flash.calls == [
pretend.call("Invalid or expired two factor login.", queue="error")
]
assert isinstance(result, HTTPSeeOther)
assert result.headers["Location"] == "redirect_to"
def test_two_factor_token_invalid(self, pyramid_request):
token_service = pretend.stub(loads=pretend.raiser(TokenException))
pyramid_request.session = pretend.stub(
flash=pretend.call_recorder(lambda *a, **kw: None)
)
pyramid_request.find_service = lambda interface, **kwargs: {
ITokenService: token_service
}[interface]
pyramid_request.route_path = pretend.call_recorder(lambda p: "redirect_to")
result = views.two_factor_and_totp_validate(pyramid_request)
assert isinstance(result, HTTPSeeOther)
assert result.headers["Location"] == "redirect_to"
assert pyramid_request.session.flash.calls == [
pretend.call("Invalid or expired two factor login.", queue="error")
]
class TestWebAuthn:
def test_webauthn_get_options_already_authenticated(self):
request = pretend.stub(user=pretend.stub(), _=lambda a: a)
result = views.webauthn_authentication_options(request)
assert result == {"fail": {"errors": ["Already authenticated"]}}
def test_webauthn_get_options_invalid_token(self, monkeypatch, pyramid_request):
_get_two_factor_data = pretend.raiser(TokenException)
monkeypatch.setattr(views, "_get_two_factor_data", _get_two_factor_data)
pyramid_request.session = pretend.stub(
flash=pretend.call_recorder(lambda *a, **kw: None)
)
result = views.webauthn_authentication_options(pyramid_request)
assert pyramid_request.session.flash.calls == [
pretend.call("Invalid or expired two factor login.", queue="error")
]
assert result == {"fail": {"errors": ["Invalid or expired two factor login."]}}
def test_webauthn_get_options(self, monkeypatch):
_get_two_factor_data = pretend.call_recorder(
lambda r: {"redirect_to": "foobar", "userid": 1}
)
monkeypatch.setattr(views, "_get_two_factor_data", _get_two_factor_data)
user_service = pretend.stub(
get_webauthn_assertion_options=lambda *a, **kw: {"not": "real"}
)
request = pretend.stub(
session=pretend.stub(
flash=pretend.call_recorder(lambda *a, **kw: None),
get_webauthn_challenge=pretend.call_recorder(lambda: "not_real"),
),
registry=pretend.stub(settings=pretend.stub(get=lambda *a: pretend.stub())),
domain=pretend.stub(),
user=None,
find_service=lambda interface, **kwargs: user_service,
)
result = views.webauthn_authentication_options(request)
assert _get_two_factor_data.calls == [pretend.call(request)]
assert result == {"not": "real"}
def test_webauthn_validate_already_authenticated(self):
# TODO: Determine why we can't use `request.user` here.
request = pretend.stub(identity=pretend.stub())
result = views.webauthn_authentication_validate(request)
assert result == {"fail": {"errors": ["Already authenticated"]}}
def test_webauthn_validate_invalid_token(self, monkeypatch, pyramid_request):
_get_two_factor_data = pretend.raiser(TokenException)
monkeypatch.setattr(views, "_get_two_factor_data", _get_two_factor_data)
pyramid_request.session = pretend.stub(
flash=pretend.call_recorder(lambda *a, **kw: None)
)
result = views.webauthn_authentication_validate(pyramid_request)
assert pyramid_request.session.flash.calls == [
pretend.call("Invalid or expired two factor login.", queue="error")
]
assert result == {"fail": {"errors": ["Invalid or expired two factor login."]}}