Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in twine.repository.upload related to print during retries #605

Closed
deveshks opened this issue Apr 24, 2020 · 3 comments · Fixed by #611
Closed

Bug in twine.repository.upload related to print during retries #605

deveshks opened this issue Apr 24, 2020 · 3 comments · Fixed by #611

Comments

@deveshks
Copy link
Contributor

In twine.repository.upload method, we use the default max_redirects value (5) in the print statement within the retry loop, but we should be using the value passed in the function.

twine/twine/repository.py

Lines 190 to 196 in 2c30b1e

print(
'Received "{status_code}: {reason}" Package upload '
"appears to have failed. Retry {retry} of 5".format(
status_code=resp.status_code,
reason=resp.reason,
retry=number_of_redirects,
)

@deveshks
Copy link
Contributor Author

Hi @bhrutledge

Now that #604 is merged, can I go ahead and create a PR for this, and update the twine.test_repository.test_upload_retry to handle this case?

@bhrutledge
Copy link
Contributor

@deveshks Please do!

@deveshks
Copy link
Contributor Author

@deveshks Please do!

Raised #611 for this

@di di closed this as completed in #611 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants