Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pipenv uninstall --dev is not working #3385

Closed
jxltom opened this issue Dec 16, 2018 · 3 comments
Closed

The pipenv uninstall --dev is not working #3385

jxltom opened this issue Dec 16, 2018 · 3 comments
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Status: Awaiting Update ⏳ This issue requires more information before assistance can be provided. triage

Comments

@jxltom
Copy link
Contributor

jxltom commented Dec 16, 2018

Issue description

The pipenv uninstall --dev is not working. The --dev flag is saved as state.installstate.dev, but it is not passed into uninstall method as shown in

retcode = do_uninstall(
packages=state.installstate.packages,
editable_packages=state.installstate.editables,
three=state.three,
python=state.python,
system=state.system,
lock=not state.installstate.skip_lock,
all_dev=all_dev,
all=all,
keep_outdated=state.installstate.keep_outdated,
pypi_mirror=state.pypi_mirror,
ctx=ctx
)
if retcode:
. Found this issue in #3345.

Expected result

The pipenv uninstall --dev should only uninstall and remove packages from dev packages section.

@jxltom jxltom added the Type: Bug 🐛 This issue is a bug. label Dec 16, 2018
@sinscary
Copy link
Contributor

sinscary commented Dec 19, 2018

@jxltom if no one is working on this, can I take it up?

@jxltom
Copy link
Contributor Author

jxltom commented Dec 19, 2018

@sinscary That's will be great! Thanks!

@matteius
Copy link
Member

matteius commented Dec 3, 2022

Is this actually still broken?

@matteius matteius added triage Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Status: Awaiting Update ⏳ This issue requires more information before assistance can be provided. and removed Type: Bug 🐛 This issue is a bug. labels Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Status: Awaiting Update ⏳ This issue requires more information before assistance can be provided. triage
Projects
None yet
Development

No branches or pull requests

3 participants