Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenv install removes comments from Pipfile #212

Closed
singleton11 opened this issue Feb 8, 2017 · 4 comments
Closed

pipenv install removes comments from Pipfile #212

singleton11 opened this issue Feb 8, 2017 · 4 comments
Labels
Type: Bug 🐛 This issue is a bug.

Comments

@singleton11
Copy link

No description provided.

@nateprewitt nateprewitt added Type: Bug 🐛 This issue is a bug. help wanted labels Feb 8, 2017
@nateprewitt
Copy link
Member

Hmm, this shouldn't be happening. It's likely part of how we're handling normalizing the Pipfile. I'll take a look into this, thanks @singleton11!

@nateprewitt
Copy link
Member

This looks to be a limitation of our upstream toml library. We'll need to raise an issue there and have them implement support for comments. We could probably implement this ourselves, but it would be nicer to get this support integrated at the source.

@nateprewitt
Copy link
Member

This is being tracked in the upstream project at uiri/toml#77. If anyone would like to take this on, that'd be super helpful! Otherwise, I'll try to start poking at this in the coming week or two.

@uiri uiri mentioned this issue Apr 11, 2017
Open
@kennethreitz
Copy link
Contributor

not anymore!

It does remove some comments, sometimes, but it mostly preserves them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug 🐛 This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennethreitz @singleton11 @nateprewitt