Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip crashes on python 3.6.1 with "cannot import name 'NoReturn'" #9879

Closed
1 task done
njsmith opened this issue Apr 26, 2021 · 3 comments
Closed
1 task done

pip crashes on python 3.6.1 with "cannot import name 'NoReturn'" #9879

njsmith opened this issue Apr 26, 2021 · 3 comments
Labels
resolution: duplicate Duplicate of an existing issue/PR

Comments

@njsmith
Copy link
Member

njsmith commented Apr 26, 2021

Description

From our CI logs:

[...]
Successfully installed pip-21.1 setuptools-56.0.0 wheel-0.36.2
+python -m pip --version
Traceback (most recent call last):
  File "/opt/python/3.6.1/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/python/3.6.1/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/travis/virtualenv/python3.6.1/lib/python3.6/site-packages/pip/__main__.py", line 29, in <module>
    from pip._internal.cli.main import main as _main
  File "/home/travis/virtualenv/python3.6.1/lib/python3.6/site-packages/pip/_internal/cli/main.py", line 9, in <module>
    from pip._internal.cli.autocompletion import autocomplete
  File "/home/travis/virtualenv/python3.6.1/lib/python3.6/site-packages/pip/_internal/cli/autocompletion.py", line 10, in <module>
    from pip._internal.cli.main_parser import create_main_parser
  File "/home/travis/virtualenv/python3.6.1/lib/python3.6/site-packages/pip/_internal/cli/main_parser.py", line 8, in <module>
    from pip._internal.cli import cmdoptions
  File "/home/travis/virtualenv/python3.6.1/lib/python3.6/site-packages/pip/_internal/cli/cmdoptions.py", line 30, in <module>
    from pip._internal.utils.hashes import STRONG_HASHES
  File "/home/travis/virtualenv/python3.6.1/lib/python3.6/site-packages/pip/_internal/utils/hashes.py", line 2, in <module>
    from typing import TYPE_CHECKING, BinaryIO, Dict, Iterator, List, NoReturn
ImportError: cannot import name 'NoReturn'

Apparently typing.NoReturn was only added in 3.6.2.

I guess we'll probably just stop testing on 3.6.1, but here's a heads up anyway.

Expected behavior

No response

pip version

21.1

Python version

3.6.1

OS

linux

How to Reproduce

see above.

Output

see above.

Code of Conduct

@njsmith njsmith added S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior labels Apr 26, 2021
@pfmoore
Copy link
Member

pfmoore commented Apr 26, 2021

Thanks. This was already reported in #9831. Technically, we only support the latest patch release of any supported CPython version, but there's a fix in #9835 which has been merged. We're currently discussing a 21.1.1 release.

@pfmoore pfmoore added resolution: duplicate Duplicate of an existing issue/PR and removed S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior labels Apr 26, 2021
@pfmoore
Copy link
Member

pfmoore commented Apr 26, 2021

I'll close this as a duplicate.

@pfmoore pfmoore closed this as completed Apr 26, 2021
@njsmith
Copy link
Member Author

njsmith commented Apr 26, 2021

Ah whoops, I only checked open issues :-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution: duplicate Duplicate of an existing issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants