Add support for MSVC 14.X to cygwinccompiler

[andrasm62]

We are using mingw32 on Windows and we got this error message:

File "C:\Users\ANDRAS~1.MEN\AppData\Local\Temp\pip-build-env-vbdit7j6\overlay\Lib\site-packages\setuptools\_distutils\cygwinccompiler.py", line 84, in get_msvcr
raise ValueError("Unknown MS Compiler version %s " % msc_ver)
ValueError: Unknown MS Compiler version 1916

Adding the MSVC 14.X compilers to the conditions would solve the problem.

We also use Anaconda. It seems like they know about this and they have inserted a hack into their distutils package. If we force to use Anaconda's distutils instead of setuptools/_distutils, we don't get this error and we can compile C codes.

Could you update this file? I saw that setuptools seems to support MSVC 14.X versions, and probably this file wasn't updated because the code coverage is 0%, because it is used just in a very special situation.

[jaraco]

I'll move this to the pypa/distutils project. I'd need someone to volunteer to help integrate the support. In the meantime, setting SETUPTOOLS_USE_DISTUTILS=stdlib will bypass the vendored copy as a workaround.

[andrasm62]

Thank you!

I think adding the missing MSVC versions from the supported WindowsCompilers from the Python Wiki to the elif conditions will solve the probleme.

[jaraco]

Thanks for providing that reference. That document indicates that Setuptools is required.

Do you know where Anaconda maintains those patches? Are they open source? Can they be incorporated here? Would you be willing to drive this effort and develop/solicit a patch to add MSVC 14 support to distutils?

[andrasm62]

After a little research I found where the patches are: https://github.com/conda-forge/python-feedstock/tree/master/recipe/patches

The actual patch for distutils is a bit dirty I think, it uses a >= operator for the msc_ver variable.
Yes, I can do a patch.

Can you help me with the steps of doing a patch? First I need to fork the project, do the changes onto a new branch, but do I need to write or run a test also?

[jaraco]

Sorry for the delayed response.

do I need to write or run a test also?

Ideally, yes. See the test_cygwincompiler for the existing tests. This project does enable running the tests with tox.

It sounds like you may be a little new to this project, so at the risk of dissuading, your best next step may be to find a mentor or partner, someone more familiar with Python development and particularly with Anaconda and Cygwin development, to assist with the effort, as I'll likely not have the bandwidth or knowledge to help effectively.

[isuruf]

Fixed in #41