-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install xbuildenv for pyodide venv
command?
#90
Comments
Not installing the xbuildenv sounds reasonable to me, but I think we should also consider the fact that it would break a lot of CI jobs downstream, where I (or others) have used Would not installing it make it possible to relax |
I'm more after relaxing the |
As for breaking tools, as long as we automatically install a |
Yes, I think we talked about downloading the pyodide runtime from NPM instead of using the files in xbuildenv (pyodide/pyodide#3730 (comment)). However, one possible usage of |
I am pretty sure it is not needed. And it currently breaks when using a different Python version because we can't find a matching Python virtual environment. We should check that the Python version matches only when building.
The text was updated successfully, but these errors were encountered: