Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor broadcast for flexible indexes #6481

Open
dcherian opened this issue Apr 13, 2022 · 0 comments · May be fixed by #8140
Open

refactor broadcast for flexible indexes #6481

dcherian opened this issue Apr 13, 2022 · 0 comments · May be fixed by #8140

Comments

@dcherian
Copy link
Contributor

What is your issue?

From @benbovy in #6477

  • extract common indexes and explicitly pass them to the Dataset and DataArray constructors (when implemented) that are called in the broadcast helper functions (there are some temporary and ugly hacks in create_default_index_implicit so that it works now with pandas multi-indexes wrapped in coordinate variables without the need to pass those indexes explicitly)
  • extract common indexes based on the dimension(s) of their coordinates and not their name (e.g., case of non-dimension but indexed coordinate)
@dcherian dcherian added needs triage Issue that has not been reviewed by xarray team member and removed needs triage Issue that has not been reviewed by xarray team member labels Apr 13, 2022
@benbovy benbovy linked a pull request Sep 3, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant