From c0481b543c9128b974098f2262fdd0e1935cd8ce Mon Sep 17 00:00:00 2001
From: Chris Holdgraf <choldgraf@berkeley.edu>
Date: Sat, 7 Jan 2023 13:26:48 +0100
Subject: [PATCH] Fixing header height (#1102)

---
 src/pydata_sphinx_theme/assets/styles/base/_base.scss          | 2 +-
 .../assets/styles/components/header/_header-logo.scss          | 3 ++-
 src/pydata_sphinx_theme/assets/styles/sections/_header.scss    | 3 ++-
 src/pydata_sphinx_theme/assets/styles/variables/_layout.scss   | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/base/_base.scss b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
index 6efc7f75c..507206dff 100644
--- a/src/pydata_sphinx_theme/assets/styles/base/_base.scss
+++ b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
@@ -1,6 +1,6 @@
 html {
   font-size: var(--pst-font-size-base);
-  scroll-padding-top: calc(var(--pst-header-height) + 12px);
+  scroll-padding-top: calc(var(--pst-header-height) + 1rem);
 }
 
 body {
diff --git a/src/pydata_sphinx_theme/assets/styles/components/header/_header-logo.scss b/src/pydata_sphinx_theme/assets/styles/components/header/_header-logo.scss
index 18d25b230..33f62989e 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/header/_header-logo.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/header/_header-logo.scss
@@ -1,8 +1,9 @@
 .navbar-brand {
   position: relative;
   height: var(--pst-header-height);
+  max-height: var(--pst-header-height);
+  padding: 0.5rem 0;
   width: auto;
-  padding: 0;
   margin: 0;
   display: flex;
   align-items: center;
diff --git a/src/pydata_sphinx_theme/assets/styles/sections/_header.scss b/src/pydata_sphinx_theme/assets/styles/sections/_header.scss
index 9d4adf3f7..bc5626455 100644
--- a/src/pydata_sphinx_theme/assets/styles/sections/_header.scss
+++ b/src/pydata_sphinx_theme/assets/styles/sections/_header.scss
@@ -13,7 +13,8 @@
   background: var(--pst-color-on-background) !important;
   box-shadow: 0 0.125rem 0.25rem 0 var(--pst-color-shadow);
 
-  min-height: var(--pst-header-height);
+  height: var(--pst-header-height);
+  max-height: var(--pst-header-height);
   width: 100%;
   padding: 0.5rem 0;
   max-width: 100vw;
diff --git a/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss b/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss
index c21b2d54b..54e63cabd 100644
--- a/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss
+++ b/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss
@@ -5,7 +5,7 @@ html {
 
   // Header height will impact the top offset for many sections
   // Article header is 66% of Header
-  --pst-header-height: 3rem;
+  --pst-header-height: 4rem;
   --pst-header-article-height: calc(var(--pst-header-height) * 2 / 3);
   --pst-sidebar-secondary: 17rem;
 }