Add IBAN Type to Types

[yezz123]

No description provided.

[HomiGrotas]

I would like to pick this issue

[HomiGrotas]

Hi, can't take this issue. Sorry😅

[kroncatti]

Hey @yezz123,

On validating the IBAN, do we intend to bring external libs such as schwifty to perform the validation or we want to implement it by ourselves ? I am asking because if that is the scenario, simply using this we would be validating the IBAN, right ?

Also, is this issue unassigned ?

[yezz123]

Hello @kroncatti I checked already Issue

Yeah, we can follow up using schwifty to validate this IBAN.

[kroncatti]

can I give it a shot ?

[yezz123]

can I give it a shot ?

Yes for sure ❤️

[kroncatti]

Thanks! as it will be my first open-source contribution, I'll eventually need help. Gonna keep you folks up to date 😄

[yezz123]

Thanks! as it will be my first open-source contribution, I'll eventually need help. Gonna keep you, folks, up to date 😄

Yes will be here for support in case you open the pull request and if its miss any thing around

[kroncatti]

Hey @yezz123 , I started to do it on this PR. Do you mind taking a fast look ?

I started thinking about using heritage with the class schwifty.IBAN, but I am not sure this is adequate here since a lot of methods may collapse and you did not use that anywhere, so I decided to follow the same pattern you folks are using. It's still missing:

• Proper testing
• Add the remaining properties.

I was wondering, is there a way to basically to inherit all the properties from schwifty.IBAN without writing explicitly ?

[yezz123]

Hey @yezz123 , I started to do it on this PR. Do you mind taking a fast look ?

I started thinking about using heritage with the class schwifty.IBAN, but I am not sure this is adequate here since a lot of methods may collapse and you did not use that anywhere, so I decided to follow the same pattern you folks are using. It's still missing:

• Proper testing
• Add the remaining properties.

I was wondering, is there a way to basically to inherit all the properties from schwifty.IBAN without writing explicitly ?

Great i will review it by today 🙏🏻

[kroncatti]

Thanks! I'll be waiting, as soon as I have a green flag on the path I am following I'll keep going 😄

[mdomke]

Since version 2023.10.0 schwifty has native support for Pydantic. Can this issue be closed then?