Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint error with toolchain version 1.83 #1560

Closed
changhc opened this issue Nov 30, 2024 · 1 comment · Fixed by #1561
Closed

Lint error with toolchain version 1.83 #1560

changhc opened this issue Nov 30, 2024 · 1 comment · Fixed by #1561

Comments

@changhc
Copy link
Contributor

changhc commented Nov 30, 2024

The stable channel had a new release 1.83 on 28 Nov. The new toolchain version brings some changes to rustfmt and clippy, and this breaks the CI lint check for my PR because the workflow uses the stable channel. I quickly made some changes in a branch (#1561) to fix this, but meanwhile I'd like to know if the team prefers to keep using stable or to pin the repo to a specific toolchain version. Maybe we should also add a rust-toolchain.toml file to make this explicit, even if the team decides to stick to stable.

Versions in the new stable toolchain:

$ cargo clippy --version
clippy 0.1.83 (90b35a6 2024-11-26)
$ cargo fmt --version      
rustfmt 1.8.0-stable (90b35a6239 2024-11-26)
$ rustc -V                  
rustc 1.83.0 (90b35a623 2024-11-26)
@davidhewitt
Copy link
Contributor

I think leaving it as stable is fine, I think there is a way to pin the workflow but I don't know if dependabot respects that; might get stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants