You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The standard library's logging module uses warning and deprecated warn. It'd be helpful to at least make warning available as logfire.warning and logfire.Logfire.warning.
This would make it a bit easier to write code that can accept either a logging.Logger or a logfire.Logfire instance (eg: library code or easier test injection).
I'm happy to submit a PR for this if you all are open to this. I see a prior commit replacing the usage of a warning method with warn, but I think the referenced PR was from a prior repo / before it was public, so I'm not sure if warning was removed intentional before.
The text was updated successfully, but these errors were encountered:
Description
The standard library's
logging
module useswarning
and deprecatedwarn
. It'd be helpful to at least makewarning
available aslogfire.warning
andlogfire.Logfire.warning
.This would make it a bit easier to write code that can accept either a
logging.Logger
or alogfire.Logfire
instance (eg: library code or easier test injection).I'm happy to submit a PR for this if you all are open to this. I see a prior commit replacing the usage of a
warning
method withwarn
, but I think the referenced PR was from a prior repo / before it was public, so I'm not sure ifwarning
was removed intentional before.The text was updated successfully, but these errors were encountered: