Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static callbacks with Python 3.x again #3350

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Jan 17, 2017

Static callbacks were disabled for Python 3.5+ to work around an issue
with subinterpreters, locking callbacks and osrandom engine. Locking
callback and osrandom engine were replaced with a C implementations in
version 1.6 and 1.7.

#2970

Closes: #3348
Signed-off-by: Christian Heimes christian@python.org

Static callbacks were disabled for Python 3.5+ to work around an issue
with subinterpreters, locking callbacks and osrandom engine. Locking
callback and osrandom engine were replaced with a C implementations in
version 1.6 and 1.7.

pyca#2970

Closes: pyca#3348
Signed-off-by: Christian Heimes <christian@python.org>
@mention-bot
Copy link

@tiran, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mhils and @alex to be potential reviewers.

@reaperhulk
Copy link
Member

import sys needs to be removed now

@reaperhulk reaperhulk merged commit d078e54 into pyca:master Jan 18, 2017
@tiran tiran deleted the static_cb_py3 branch January 18, 2017 12:40
@tiran
Copy link
Contributor Author

tiran commented Jan 18, 2017

Thanks for the fix up!

@reaperhulk reaperhulk mentioned this pull request Jan 28, 2017
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 28, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Enable Cryptography_STATIC_CALLBACKS for Python 3
3 participants