-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add black to workflow #44
Comments
@toncho FYI |
Yes, we speak about this. It is possible to convert the repo to use black formatting, the major drawback is that it messes up with the history of commits and that tools like git blame are obscured afterwards. |
In the example above, when we will open a PR, the action will open a new pull request against the branch on which is based the initial PR. Once reviewed, the changes will be merged into this initial PR and included in the commit history of the PR. |
Thanks for the explanation. This action seems a little bit complicated, especially for a tool like black that is made to be automatic and straightforward. If we want to use black, it is better to simply use it in pre-commit or as a linting test (as proposed in the official doc) |
A pre-commit hook could be complicated to share because they are not included into version control (except may be with Husky). |
@qbarthelemy @sylvchev
There is an issue on pyriemann repo about using black to auto format the code.
I wonder if we could tried this here. What do you think?
The text was updated successfully, but these errors were encountered: