-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error generating androidTWA package: keytool failed on unicode characters #1191
Comments
Hello ynonra, thank you for opening an issue with us! I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌 |
Shalom @ynonra I suspect the issue is that the Android SDK tool, keytool, is having trouble with Hebrew characters as your organization name. As a test, can you try generating your Android app using English letters for the organization name? In the meanwhile, I'll report this bug to the Google team that owns this piece of the stack. |
@andreban Bubblewrap fails for this guy, with the following error message. Possibly related to unicode support in either Bubblewrap or keytool?
|
thanks a lot, i changed all the names to english and it works! is there a way to edit the files manualy and return the original hebrew names? |
Not that I'm aware of. You might be glad to know the organization here is used for creating a signing key only. The key is used to sign your Android app package. I don't think the organization is displayed anywhere to end users. |
I can confirm those details are not shown to users anywhere. Anyway, it turns out the problem is the comma in the keytool -genkeypair -dname "cn=tikun Admin, ou=Engineering, o=תיקון קוראים נוח ובהיר\, ולימוד טעמי מקרא והפטרה, c=US" -alias "my-key-alias" -keypass "637kqXPmNXC8" -keystore "signingKey.keystore" -storepass "n6JhhCrfSmfX" -validity 20000 -keyalg RSA @JudahGabriel we can either escape this in @bubblewrap/core before running the command or escape it in PWA Builder and in @bubblewrap/cli. I'm happy either way, but might be good to discuss the approach first to avoid escaping twice. |
thanks guys! |
Filed GoogleChromeLabs/bubblewrap#373 for Bubblewrap |
I received the following error when generating a package for https://www.tikunkorim.co.il/
The text was updated successfully, but these errors were encountered: