From 5e6b950c3eff8ccc8f5bb330be5f8e5f7d6ab918 Mon Sep 17 00:00:00 2001 From: Chirag Pachori Date: Tue, 16 Aug 2022 15:44:21 -0700 Subject: [PATCH 1/4] Description for tracking.calc_cross_axis_tilt The previous description for the signs of cross axis tilt mentioned slope azimuth as east for both positive and negative. Corrected it to indicate that sign of cross axis tilt is positive when axis azimuth is south and slope is towards west. --- pvlib/tracking.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index 9bd216207d..2b5dd742d3 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -54,7 +54,7 @@ class SingleAxisTracker(PVSystem): using a right-handed convention. For example, trackers with axis azimuth of 180 degrees (heading south) will have a negative cross-axis tilt if the tracker axes plane slopes down to the east and positive - cross-axis tilt if the tracker axes plane slopes up to the east. Use + cross-axis tilt if the tracker axes plane slopes up to the west. Use :func:`~pvlib.tracking.calc_cross_axis_tilt` to calculate `cross_axis_tilt`. [degrees] @@ -329,7 +329,7 @@ def singleaxis(apparent_zenith, apparent_azimuth, using a right-handed convention. For example, trackers with axis azimuth of 180 degrees (heading south) will have a negative cross-axis tilt if the tracker axes plane slopes down to the east and positive - cross-axis tilt if the tracker axes plane slopes up to the east. Use + cross-axis tilt if the tracker axes plane slopes up to the west. Use :func:`~pvlib.tracking.calc_cross_axis_tilt` to calculate `cross_axis_tilt`. [degrees] @@ -631,7 +631,7 @@ def calc_cross_axis_tilt( specified using a right-handed convention. For example, trackers with axis azimuth of 180 degrees (heading south) will have a negative cross-axis tilt if the tracker axes plane slopes down to the east and positive cross-axis - tilt if the tracker axes plane slopes up to the east. + tilt if the tracker axes plane slopes up to the west. Parameters ---------- From 17e90e9745f94c6101a8f9c2711d9c3bcd39a1a6 Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Wed, 14 Sep 2022 08:40:19 -0600 Subject: [PATCH 2/4] up to down --- docs/sphinx/source/whatsnew/v0.9.3.rst | 4 +++- pvlib/tracking.py | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.3.rst b/docs/sphinx/source/whatsnew/v0.9.3.rst index 60054f6482..5dd7315010 100644 --- a/docs/sphinx/source/whatsnew/v0.9.3.rst +++ b/docs/sphinx/source/whatsnew/v0.9.3.rst @@ -35,6 +35,7 @@ Testing Documentation ~~~~~~~~~~~~~ +* Clarified description of cross-axis slope in :py:mod:`pvlib.tracking.py` (:pull:`1530`) Benchmarking @@ -57,4 +58,5 @@ Contributors * Mark Campanelli (:ghuser:`markcampanelli`) * Adam R. Jensen (:ghuser:`AdamRJensen`) * Abhishek Parikh (:ghuser:`abhisheksparikh`) -* Taos Transue (:ghuser:`reepoi`) \ No newline at end of file +* Taos Transue (:ghuser:`reepoi`) +* (:ghuser:`chirapachori`) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index f584bc289f..9ae148447f 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -54,7 +54,7 @@ class SingleAxisTracker(PVSystem): using a right-handed convention. For example, trackers with axis azimuth of 180 degrees (heading south) will have a negative cross-axis tilt if the tracker axes plane slopes down to the east and positive - cross-axis tilt if the tracker axes plane slopes up to the west. Use + cross-axis tilt if the tracker axes plane slopes down to the west. Use :func:`~pvlib.tracking.calc_cross_axis_tilt` to calculate `cross_axis_tilt`. [degrees] @@ -339,7 +339,7 @@ def singleaxis(apparent_zenith, apparent_azimuth, using a right-handed convention. For example, trackers with axis azimuth of 180 degrees (heading south) will have a negative cross-axis tilt if the tracker axes plane slopes down to the east and positive - cross-axis tilt if the tracker axes plane slopes up to the west. Use + cross-axis tilt if the tracker axes plane slopes down to the west. Use :func:`~pvlib.tracking.calc_cross_axis_tilt` to calculate `cross_axis_tilt`. [degrees] @@ -641,7 +641,7 @@ def calc_cross_axis_tilt( specified using a right-handed convention. For example, trackers with axis azimuth of 180 degrees (heading south) will have a negative cross-axis tilt if the tracker axes plane slopes down to the east and positive cross-axis - tilt if the tracker axes plane slopes up to the west. + tilt if the tracker axes plane slopes down to the west. Parameters ---------- From 8a5fc59ba88096261ce792563e68b93e9caa9ad2 Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Wed, 14 Sep 2022 09:02:17 -0600 Subject: [PATCH 3/4] Update docs/sphinx/source/whatsnew/v0.9.3.rst Co-authored-by: Kevin Anderson --- docs/sphinx/source/whatsnew/v0.9.3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.3.rst b/docs/sphinx/source/whatsnew/v0.9.3.rst index 5dd7315010..8e1945856b 100644 --- a/docs/sphinx/source/whatsnew/v0.9.3.rst +++ b/docs/sphinx/source/whatsnew/v0.9.3.rst @@ -35,7 +35,7 @@ Testing Documentation ~~~~~~~~~~~~~ -* Clarified description of cross-axis slope in :py:mod:`pvlib.tracking.py` (:pull:`1530`) +* Clarified description of cross-axis slope in :py:mod:`pvlib.tracking` (:pull:`1530`) Benchmarking From ec40e0b8099e9e1437445795ccb6060566386850 Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Wed, 14 Sep 2022 09:02:22 -0600 Subject: [PATCH 4/4] Update docs/sphinx/source/whatsnew/v0.9.3.rst Co-authored-by: Kevin Anderson --- docs/sphinx/source/whatsnew/v0.9.3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.3.rst b/docs/sphinx/source/whatsnew/v0.9.3.rst index 8e1945856b..3c8279ce9c 100644 --- a/docs/sphinx/source/whatsnew/v0.9.3.rst +++ b/docs/sphinx/source/whatsnew/v0.9.3.rst @@ -59,4 +59,4 @@ Contributors * Adam R. Jensen (:ghuser:`AdamRJensen`) * Abhishek Parikh (:ghuser:`abhisheksparikh`) * Taos Transue (:ghuser:`reepoi`) -* (:ghuser:`chirapachori`) +* (:ghuser:`chiragpachori`)