Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why remove parallelization for bifacial.py? #997

Closed
toddkarin opened this issue Jul 6, 2020 · 2 comments
Closed

Why remove parallelization for bifacial.py? #997

toddkarin opened this issue Jul 6, 2020 · 2 comments

Comments

@toddkarin
Copy link

Previous versions of pvlib had a run_parallel_calculations=True option in bifacial.pvfactors_timeseries(). Why was this removed in the current version?

Ideally I'd like to see parallel calculations restored.

The default could be to set run_parallel_calculations=False, which might help with avoiding runtime errors.

@kandersolar
Copy link
Member

Hey @toddkarin, my understanding is that the parallelization is not necessary or desirable anymore because of improved vectorization in pvfactors -- see the discussion here: #934 (comment)

Is that inconsistent with your experience? If you're seeing a difference, we might need to take another look at that decision.

This is another time that #419 would be handy.

@toddkarin
Copy link
Author

Thanks for the reference to #934. My main problem was that the change broke my code.

Unfortunately, I can't easily benchmark the parallel code because I've installed pvfactors 1.4.1. So, let's just call this good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants