Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default solar constant #1566

Open
kdebrab opened this issue Oct 5, 2022 · 5 comments
Open

Update default solar constant #1566

kdebrab opened this issue Oct 5, 2022 · 5 comments

Comments

@kdebrab
Copy link
Contributor

kdebrab commented Oct 5, 2022

The default solar constant used in irradiance.get_extra_radiation is currently 1366.1 W/m².

Recent work revised the average solar constant to 1361.1 W/m² (see https://www.researchgate.net/publication/324269776_A_reevaluation_of_the_solar_constant_based_on_a_42-year_total_solar_irradiance_time_series_and_a_reconciliation_of_spaceborne_observations).

This new value seems now to be gaining broad acceptance, a.o. in certain standards.

Maybe it's a good time to update also the default value in pvlib to 1361.1 W/m².

@mikofski
Copy link
Member

mikofski commented Oct 5, 2022

I think this should be an input with a recommended default I realize I don't know what I'm talking about.

@kandersolar
Copy link
Member

I think this should be an input with a recommended default

I've been frustrated by irradiance.disc not exposing the solar constant value as an input, so +1 from me.

Regarding default values: if a model was tuned for a specific value of the solar constant then I'm not sure it makes sense to go against its reference by changing the default.

@cwhanse
Copy link
Member

cwhanse commented Oct 5, 2022

That function is a convenience wrapper for four extraterrestrial irradiance models, which all differ in how the earth-Sun distance is computed. Two of the models also specify a solar constant: 'asce' uses 1367.7 and 'spencer' uses 1366.1. 'pyephem' refers to the ephem python package, which doesn't contain a solar constant that I have found, and 'nrel' refers to SPA and there is no specified solar constant for either.

So we could make the solar constant an input to this function, but I'd want to specify the values for 'asce' and 'spencer'.

@adriesse
Copy link
Member

@cwhanse The constant and the method to calculate sun-earth distance are independent of each other.

The constant probably only matters for the clear-sky models, where the best value to use may be the one used at the time the model was developed. Plopping in the new value everywhere would probably create a bit of a bias.

@cwhanse
Copy link
Member

cwhanse commented Oct 13, 2022

The constant and the method to calculate sun-earth distance are independent of each other.

I agree, I'm thinking to maintain consistency with the underlying reference for those two extraterrestrial irradiance models which specify a constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants