From cc9a5cff79934755de209d66a8ea63aebb742715 Mon Sep 17 00:00:00 2001 From: Jay Chung Date: Mon, 31 Jul 2023 16:24:49 +0800 Subject: [PATCH] Use set in fetch_columns for efficient (#5336) Change list to set --- redash/query_runner/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/redash/query_runner/__init__.py b/redash/query_runner/__init__.py index fda7a3da7c..451c76868a 100644 --- a/redash/query_runner/__init__.py +++ b/redash/query_runner/__init__.py @@ -212,7 +212,7 @@ def run_query(self, query, user): raise NotImplementedError() def fetch_columns(self, columns): - column_names = [] + column_names = set() duplicates_counter = 1 new_columns = [] @@ -222,7 +222,7 @@ def fetch_columns(self, columns): column_name = "{}{}".format(column_name, duplicates_counter) duplicates_counter += 1 - column_names.append(column_name) + column_names.add(column_name) new_columns.append({"name": column_name, "friendly_name": column_name, "type": col[1]}) return new_columns