-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Use SocketRocket v0.4 #181
Comments
Thanks, I'll wait to review what has changed first but would be good to move to the new version - good to see some movement on that project at last! |
Some Pusher users are reporting that app submissions to the app store are being rejected because of SocketRocket using internal API names, as described here: facebookincubator/SocketRocket#226 Updating to 0.4 would include the fix for this issue (as shown in this PR facebookincubator/SocketRocket#252) so if you get a chance to look at this Luke it'd be much appreciated 👍 |
After updating to SocketRocket 0.4, it looks like there are still selector names matching those of private APIs. Specifically:
|
@brandons there is a commit in a fork to rename those two names here: kommen/SocketRocket@db8c681 Are you using cocoapods? If so, you can reference that fork to get the changes in, or you can make you're own fork while waiting for the fixes to be merged into socketrocket's master branch |
@hamchapman Yes. We're using this fork in our project now, but it's certainly not ideal. Cocoapods does not allow you to specify a git repo for a dependency in a Podspec, making this much more messy. |
@brandons Interesting, perhaps you can submit an issue for that feature at the CocoaPods repo? 😄 |
Closed by #185 |
Please see the new 1.6.1 release |
SocketRocket has just recently been updated with a new tag: https://github.com/square/SocketRocket/tree/0.4
The text was updated successfully, but these errors were encountered: