Add backslash support to registry resource #124
Conversation
Added a new value_name property to handle more complex values Kept backwards compatibility by handling empty values and creating 'value_name' using the last element in the key path.
|
Looks like I need to clean up some tests :) |
|
@sbrito85 thanks for the PR! I've added this to triage and it will be reviewed this week. While that happens, could you review the CONTRIBUTING.md file and update your commits? Specifically referring to commit message section. Also, we will need to add a spec test for this. If you don't have time to do so, I will add it before the PR is merged |
| @@ -103,7 +103,7 @@ def eval_generate | |||
|
|
|||
| # get the "should" names of registry values associated with this key | |||
| should_values = catalog.relationship_graph.direct_dependents_of(self).select {|dep| dep.type == :registry_value }.map do |reg| | |||
| PuppetX::Puppetlabs::Registry::RegistryValuePath.new(reg.parameter(:path).value).valuename | |||
| PuppetX::Puppetlabs::Registry::RegistryValuePath.new(reg.parameter(:path).value, reg.parameter(:value_name).value).valuename | |||
There was a problem hiding this comment.
Does this mean it's a breaking change? As in, do users using the old syntax have to use this new syntax?
There was a problem hiding this comment.
Old syntax still works from all tests that I've done. This should not be a breaking change.
|
Hi @sbrito85. Thanks for all your work on this so far. I have some concerns about it;
|
|
I plan on having some cycles this week to look at these concerns. Sorry for the delay!
|
|
I started work on squashing your commits, and then adding tests. Commits are here; This is what tripped me up with autorequire as those tests were failing. The autorequire code is here Note it's using the resource name not the non-backslash value. |
|
Any update on this? Really looking forward to this being available for our company. |
|
Any Update? This would reallly be nice... |
Puppet bug here: https://tickets.puppetlabs.com/browse/MODULES-2957
Picked up the work being done on other pull requests.