Elasticsearch Repository For 2.x versions changed

[peterbucher]

The repositories for the elasticsearch 2.x versions changes, thus the code which asks for a specific Major.Minor.X version and delegates to a specific repo version vor 2.x needs to be changed. Else, elasticsearch is not found and vagrant does not boot up.

I used the latest vagrant, virtualbox, puphpet.

See:

• https://github.com/puphpet/puppet-puphpet/blob/master/manifests/elasticsearch/install.pp#L43
• https://discuss.elastic.co/t/is-there-a-problem-w-2-3-repository/45902
• http://packages.elastic.co/elasticsearch/2.x/debian/dists/stable/main/binary-amd64/Packages

Original code:

  if $version {
    if versioncmp($version, '6') >= 0 {
      $repo_version = '6.x'
    }
    elsif versioncmp($version, '5') >= 0 {
      $repo_version = '5.x'
    }
    elsif versioncmp($version, '2.4') >= 0 {
      $repo_version = '2.4'
    }
    elsif versioncmp($version, '2.3') >= 0 {
      $repo_version = '2.3'
    }
    elsif versioncmp($version, '2.2') >= 0 {
      $repo_version = '2.2'
    }
    elsif versioncmp($version, '2.1') >= 0 {
      $repo_version = '2.1'
    }
    elsif versioncmp($version, '2.0') >= 0 {
      $repo_version = '2.0'
    }
  }

Needed changes:
On every "$repo_version = 2....., it should be changed to 2.x to work again.

Working example for 2.4:

    elsif versioncmp($version, '2.4') >= 0 {
      $repo_version = '2.x'
    }

Also to mention: If a repo_version is given by the config.yaml, it will be overridden by this very code. I do think it should work exactly the oposity, that config.yaml overrides this hard coded assignments?