Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off Systemd integration #3424

Closed
mohamedhafez opened this issue Jul 14, 2024 · 1 comment · Fixed by #3425
Closed

Option to turn off Systemd integration #3424

mohamedhafez opened this issue Jul 14, 2024 · 1 comment · Fixed by #3425

Comments

@mohamedhafez
Copy link
Contributor

So in

if ENV["NOTIFY_SOCKET"] && !Puma.jruby?
@config.plugins.create('systemd')
end
we load the Systemd integration if the NOTIFY_SOCKET is set.

It would be great to have the option to opt out of this, say if ENV["PUMA_SKIP_SYSTEMD"] is set.

In my case I'd like this because in one of my background daemons, I run Puma in a thread with Rack::Handler::Puma.run just as an interface to the daemon. However, since the daemon does way more that Puma doesn't know about, I deal with systemd integration elsewhere in that daemon. Currently I'm just monkeypatching the lines above to turn off the automatic Puma integration.

@dentarg
Copy link
Member

dentarg commented Jul 14, 2024

Makes sense to me 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants