Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some read methods don't work for import #311

Closed
IaroslavTitov opened this issue Jun 7, 2024 · 4 comments
Closed

Some read methods don't work for import #311

IaroslavTitov opened this issue Jun 7, 2024 · 4 comments
Assignees
@IaroslavTitov
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.108

Comments

@IaroslavTitov
Copy link
Contributor

What happened?

While working on #310, I noticed that we have more resources whose Read methods use GetProperties() method, which returns empty in case of import operation. This will clearly break import, so we need to fix these.

Example

List of all resources that need to be fixed:

  • AccessToken
  • AgentPool
  • EnvironmentVersionTag
  • Environment
  • OrgAccessToken
  • StackTag
  • TeamAccessToken

Output of pulumi about

Not relevant

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@IaroslavTitov IaroslavTitov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jun 7, 2024
@IaroslavTitov IaroslavTitov self-assigned this Jun 7, 2024
@IaroslavTitov IaroslavTitov added this to the 0.106 milestone Jun 7, 2024
@IaroslavTitov IaroslavTitov removed the needs-triage Needs attention from the triage team label Jun 10, 2024
@IaroslavTitov
Copy link
Contributor Author

Access token fixed in #341

@IaroslavTitov IaroslavTitov modified the milestones: 0.106, 0.107 Jul 1, 2024
@IaroslavTitov
Copy link
Contributor Author

AgentPool fixed in #343

@IaroslavTitov IaroslavTitov modified the milestones: 0.107, 0.108 Jul 22, 2024
@IaroslavTitov
Copy link
Contributor Author

EnvironmentVersionTag fixed in #353

Environment fixed in #326 (as part of unrelated bug)

OrgAccessToken fixed in #354

StackTag fixed in #360

TeamAccessToken fixed in #361

@IaroslavTitov IaroslavTitov added the resolution/fixed This issue was fixed label Jul 22, 2024
@IaroslavTitov
Copy link
Contributor Author

All are fixed, resolving issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IaroslavTitov IaroslavTitov

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.108
Development

No branches or pull requests
1 participant
@IaroslavTitov