Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Node.js examples #155

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Clean up Node.js examples #155

merged 3 commits into from
Sep 2, 2020

Conversation

mikhailshilkov
Copy link
Member

  • Rely on yarn link instead of local imports
  • Use per-namespace naming for faster execution and grouping of versions
  • Random names
  • Remove tags
  • Add three more examples as tests

stack72
stack72 reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Python SDK regenerated locally so it copies the README but apart from that it's GTG

@mikhailshilkov mikhailshilkov force-pushed the mikhailshilkov/node-examples branch from 35803d7 to a18dc85 Compare September 2, 2020 11:31
@mikhailshilkov mikhailshilkov merged commit 5ec4947 into master Sep 2, 2020
@pulumi-bot pulumi-bot deleted the mikhailshilkov/node-examples branch September 2, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikhailshilkov @stack72