New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spreading attributes from object requires comma #101

Closed

ezhlobo opened this issue May 30, 2019 · 3 comments

Member

ezhlobo commented May 30, 2019

Better to show an example:

Invalid

button(type="button" ...props)

Valid

button(type="button", ...props)

Will be nice to have both cases working.

Member

ForbesLindesay commented May 30, 2019

This should just be a case of treating ... as a special case like we do with : in https://github.com/pugjs/pug/blob/2f1110ec2ed8656253331e1e4b1b20b9d12185ee/packages/pug-lexer/index.js#L1221

Member Author

ezhlobo commented Jun 15, 2019

@ForbesLindesay thank you, that helped! Created pull request to pug-lexer:

ezhlobo mentioned this issue

Fix spread attribute #102

Merged

Member Author

ezhlobo commented Jun 19, 2019

Fixed in v7.0.1

ezhlobo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment