Fixed Pagination issue

[gaurav2699]

Fixes #9290 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@1b54747). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e5f16aa differs from pull request most recent head 64bdb76. Consider uploading reports for the commit 64bdb76 to get more accurate results

@@           Coverage Diff           @@
##             main    #9330   +/-   ##
=======================================
  Coverage        ?   82.09%           
=======================================
  Files           ?       98           
  Lines           ?     5870           
  Branches        ?        0           
=======================================
  Hits            ?     4819           
  Misses          ?     1051           
  Partials        ?        0           

[gaurav2699]

@cesswairimu @jywarren please review

[RuthNjeri]

Hi, @gaurav2699 also noting this issue #714 that aims to remove all references to tool and place, which could render your code obsolete

[gaurav2699]

@RuthNjeri You can check now. Thanks!

[gitpod-io]

[gitpod-io]

[Tlazypanda]

@gaurav2699 LGTM 🎉 can we also write a functional test to make sure this doesn't break later?

[gaurav2699]

@Tlazypanda I added a functional test, please review and check if it's alright! Thanks a lot!

[cesswairimu]

Hi @gaurav2699 , there are one test that was added on main that is failing because of the new wikis created in your test block...would you like to help make these a little more dynamic this would involve changing this test to smth like

test 'should sort by last edited' do
   get :index, params: { sort: "last_edited" }
   wikis = assigns(:wikis)
   wiki1 = wikis.order(changed: :desc).first
   wiki2 = wikis.order(changed: :desc).reverse.first
   assert_equal(wikis.first.title, wiki1.title)
   assert_equal(wikis.last.title, wiki2.title)
end

what do you think? Thanks

[codeclimate]

Code Climate has analyzed commit 64bdb76 and detected 0 issues on this pull request.

View more on Code Climate.

[gaurav2699]

Thanks for the guidance @cesswairimu. I made the change and now the functional tests doesn't fail. Please review. Thanks a lot.

[cesswairimu]

Fantastic thanks 🎉

[cesswairimu]

Great great job here @gaurav2699 thanks a lot