changed function "t" to "translation" on line 23 and 26. #6768
Conversation
changed function "t" to "translation" on line 23 and 26.
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
this is my Twitter handle - @iampmukherjee
Thanks,
Priyajit M.
…On Tue, Nov 12, 2019 at 2:30 PM welcome[bot] ***@***.***> wrote:
Thanks for opening this pull request! This space is protected by our Code
of Conduct <https://publiclab.org/conduct> - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers
and requests.
Also please refer here <#3840>
for installation help 💿
There may be some errors, *but don't worry!* We'll work through them with
you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank
you properly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6768?email_source=notifications&email_token=ACXALKP7KI5PXNTTOFADCCTQTJWC7A5CNFSM4JMAJAQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDZQS5Q#issuecomment-552798582>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXALKKYYHNDTSAQWNCNUYLQTJWC7ANCNFSM4JMAJAQA>
.
|
|
I'm not sure why that's failing, it's been doing that a lot lately. It should be an issue, nothing you did! Can you change the Issue # at the top in your post to the issue that this fixes? #6736 Thanks! |
|
Awesome! I'm working on another fix for the thumbnails file, so I'm going to hold off a little bit before merging this, but this looks great! |
Screenshots 📸 (click to expand)6768-test_questions.png6768-test_embeddable_grids.png6768-test_signup.png6768-test_viewing_the_settings_page.png6768-test_tag_by_author_page.png6768-test_wiki_page_with_inline_grids.png6768-test_stats.png6768-test_viewing_the_dashboard.png6768-test_searching_an_item_from_the_homepage.png6768-test_questions_shadow.png6768-test_login_modal.png6768-test_profile_page.png6768-test_comments.png6768-test_tags.png6768-test_signup_modal.png6768-test_wiki.png6768-test_methods.png6768-test_tag_page.png6768-test_blog_page_with_location_modal.png6768-test_tag_wildcard.png6768-test_embeddable_thumbnail_grids.png6768-test_front_page_with_navbar_search_autocomplete.png6768-test_login.png6768-test_viewing_the_dropdown_menu.png6768-test_viewing_question_post.png6768-test_mobile_displays.png6768-test_simple-data-grapher_powertag.png6768-test_front.png6768-test_question_page.png6768-test_tag_contributors_page.png6768-test_blog.png6768-test_people.png6768-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
|
@jywarren what is the status of related PRs? |
|
I'm not sure, maybe @nstjean could offer an update and we could tidy up the
remaining open PRs?
…On Tue, Jan 7, 2020 at 12:44 PM Sidharth Bansal ***@***.***> wrote:
@jywarren <https://github.com/jywarren> what is the status of related PRs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6768?email_source=notifications&email_token=AAAF6J2OCZXSZTN3FGQQCXTQ4S43PA5CNFSM4JMAJAQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJVLWA#issuecomment-571692504>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J3HLRMYBJ54YM6OXW3Q4S43PANCNFSM4JMAJAQA>
.
|
|
Hi @SidharthBansal ! The full list is here #6579 - templates that have a FTO created are checked off with links to the issues. It is up to date. Do you want me to mark off which have been merged and which haven't? |
|
yeah, please |
|
@SidharthBansal Ok I'll get that done! |
|
Any progress on this? |
1 similar comment
|
Any progress on this? |
|
Ahh, sorry! I got caught up in testing issues. I'll go through it today! |
Codecov Report
@@ Coverage Diff @@
## master #6768 +/- ##
=========================================
Coverage ? 81.90%
=========================================
Files ? 97
Lines ? 5615
Branches ? 0
=========================================
Hits ? 4599
Misses ? 1016
Partials ? 0 |
|
This PR has been open for a long time and no activity/ reviews requested has not been addressed. We understand you might be busy and engaged on other things. I am closing this for now...please feel free to reopen if you get some time and would like to finish this. Rem to check if its still available before you reopen. Thanks |
changed function "t" to "translation" on line 23 and 26.
Fixes #6736
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!