Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update_comment_moderate.html.erb #6555

Closed
wants to merge 1 commit into from

Conversation

saivoleti17
Copy link

Changed function name 't' to 'translation'

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Changed function name 't' to 'translation'
@cesswairimu
Copy link
Collaborator

Hi @saivoleti17, could you please add the issue number on the description. Thanks

@SidharthBansal
Copy link
Member

@nstjean did you see the localhost before approving?

@nstjean
Copy link
Contributor

nstjean commented Dec 23, 2019

I do not remember, so I fetched and checked. Here you go!

FireShot Capture 127 - 🎈 Public Lab_ Dashboard - localhost

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 23, 2019 via email

@nstjean
Copy link
Contributor

nstjean commented Dec 24, 2019

I don't know why that test is failing? Does that need to be investigated? Or the test restarted?

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 24, 2019 via email

@SidharthBansal
Copy link
Member

@jywarren i think we had same error in some other prs. Can you please recall the fix?
Thanks

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

Could we try rebasing this to see if it passes?

@nstjean
Copy link
Contributor

nstjean commented Mar 17, 2020

Closing this as it's been a long while.

@nstjean nstjean closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants