-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update_comment_moderate.html.erb #6555
Conversation
Changed function name 't' to 'translation'
Hi @saivoleti17, could you please add the issue number on the description. Thanks |
@nstjean did you see the localhost before approving? |
So is it good to merge?
…On Mon, 23 Dec 2019, 8:00 pm Natalie St Jean, ***@***.***> wrote:
I do not remember, so I fetched and checked. Here you go!
[image: FireShot Capture 127 - 🎈 Public Lab_ Dashboard - localhost]
<https://user-images.githubusercontent.com/49460529/71363352-d6de3480-2566-11ea-910b-6d3b29b0aacc.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6555?email_source=notifications&email_token=AFAAEQ6EAGEPM5EMXR5BNCTQ2DDQDA5CNFSM4JFK56E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRHTXA#issuecomment-568490460>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQYNBVHQOLBSPNEPOZDQ2DDQDANCNFSM4JFK56EQ>
.
|
I don't know why that test is failing? Does that need to be investigated? Or the test restarted? |
Let's restart the test first.
…On Tue, 24 Dec 2019, 8:12 pm Natalie St Jean, ***@***.***> wrote:
I don't know why that test is failing? Does that need to be investigated?
Or the test restarted?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6555?email_source=notifications&email_token=AFAAEQ4XZ7DYGLE3W2A7MXDQ2INUBA5CNFSM4JFK56E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTJOKY#issuecomment-568760107>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQZ5VP275S2HKNYGHTTQ2INUBANCNFSM4JFK56EQ>
.
|
@jywarren i think we had same error in some other prs. Can you please recall the fix? |
Could we try rebasing this to see if it passes? |
Closing this as it's been a long while. |
Changed function name 't' to 'translation'
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!