Add more tests for Node (for note and wiki page titles)

app/models/node.rb

@@ -1,14 +1,12 @@
 class UniqueUrlValidator < ActiveModel::Validator
   def validate(record)
-    if record.title == '' || record.title.nil?
-      # record.errors[:base] << "You must provide a title."
+    if record.title.blank?
+      record.errors[:base] << "You must provide a title."
       # otherwise the below title uniqueness check fails, as title presence validation doesn't run until after
     elsif record.type == 'page'
       array = %w(create edit update delete new)
-      array.each do |x|
-        if record.title == x
-          record.errors[:base] << "You may not use the title '" + x + "'"
-        end
+      if array.include? record.title.downcase
+        record.errors[:base] << "You may not use the title '#{record.title}'"
       end
     else
       if !Node.where(path: record.generate_path).first.nil? && record.type == 'note'
@@ -96,7 +94,7 @@ def updated_month
 
   belongs_to :user, foreign_key: 'uid'
 
-  validates :title, presence: true
+  validates :title, presence: true, length: { minimum: 3 }
   validates_with UniqueUrlValidator, on: :create
 
   scope :published, -> { where(status: 1) }

test/functional/notes_controller_test.rb

@@ -418,7 +418,7 @@ def teardown
     assert_response :success
     assert_not_nil @response.body
     json = JSON.parse(@response.body)
-    assert_equal ["can't be blank"], json['title']
+    assert_equal ["can't be blank", "is too short (minimum is 3 characters)"], json['title']
     assert !json['title'].empty?
   end
 

test/unit/node_test.rb

@@ -210,6 +210,41 @@ def setup
     assert_equal 'Wiki page content/body', node.body
   end
 
+  test 'wikipage with wrong title should not be created' do
+    node = Node.new(uid: users(:bob).id,
+                    type: 'page')
+    words = %w(create update delete new edit)
+    words.each do |word|
+      node.title = word.capitalize
+      assert_not node.save
+    end
+  end
+
+  test 'research note with empty/blank title should not be created' do
+    node = Node.new(uid: users(:bob).id,
+                    type: 'note')
+    titles = [ '', ' ' * 5 ]
+    titles.each do |t|
+      node.title = t
+      assert_not node.valid?
+    end
+  end
+
+  test 'research note with duplicate title should not be created' do
+    node = Node.new(uid: users(:bob).id,
+                    type: 'note',
+                    title: 'My research note')
+    dup_node = node.dup
+    node.save
+    assert_not dup_node.save
+  end
+
+  test 'title should not be too short' do
+    node = Node.new(uid: users(:bob).id,
+                    type: 'note',
+                    title: 'ok')
+    assert_not node.valid?
+  end
   test 'create a node_revision' do
     # in testing, uid and id should be matched, although this is not yet true in production db
     revision_count = nodes(:one).revisions.length