Add comments Statuses to data model documentation #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@publiclab/reviewers check this out please! |
|
@dinaelhanan I cannot look at this right now but I added a label onto it to try and get it some attention :) |
Generated by 🚫 Danger |
grvsachdeva
reviewed
Dec 17, 2018
grvsachdeva
reviewed
Dec 17, 2018
grvsachdeva
reviewed
Dec 17, 2018
doc/DATA_MODEL.md
Outdated
| * 3: draft | ||
| * 4: moderated -- i.e. node created by a first-time poster, and has not yet been "approved" | ||
|
|
||
| The status for Node is now the same for comment in our Code base except for status = 5 |
There was a problem hiding this comment.
How about removing this line? @dinaelhanan
There was a problem hiding this comment.
ok, will do. Thanks!
|
Some changes to do @dinaelhanan and nice work 🎉. Thanks! |
Co-Authored-By: dinaelhanan <dinaelhanan@gmail.com>
Co-Authored-By: dinaelhanan <dinaelhanan@gmail.com>
|
@gauravano done. Thanks! |
grvsachdeva
reviewed
Dec 18, 2018
doc/DATA_MODEL.md
Outdated
|
|
||
| * 0: banned | ||
| * 1: normal | ||
| * 3: draft |
There was a problem hiding this comment.
Suggested change
| * 3: draft |
I forgot to tell you about removing draft status too 😐.
There was a problem hiding this comment.
ok, I have made the change!
grvsachdeva
approved these changes
Dec 18, 2018
|
Merged 💯 🎈 |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Update node_tags.yml * Update admin_controller_test.rb * Update admin_controller_test.rb * Update DATA_MODEL.md * Update DATA_MODEL.md * Update node_tags.yml * Update doc/DATA_MODEL.md Co-Authored-By: dinaelhanan <dinaelhanan@gmail.com> * Update doc/DATA_MODEL.md Co-Authored-By: dinaelhanan <dinaelhanan@gmail.com> * Update DATA_MODEL.md * Quick fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Part of #3331
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!