Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeClimate documentation #3068

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Add CodeClimate documentation #3068

merged 2 commits into from
Jul 17, 2018

Conversation

stefannibrasil
Copy link

@stefannibrasil stefannibrasil commented Jul 15, 2018 •
edited
Loading

@jywarren what do you think about this? is it okay to add the images on that folder? Thanks!

@ghost ghost assigned stefannibrasil Jul 15, 2018
@ghost ghost added the in progress label Jul 15, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Jul 15, 2018 •
edited
Loading

2 Messages
📖 @stefannibrasil Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@milaaraujo milaaraujo added the rgsoc Rails Girls Summer of Code label Jul 15, 2018
@jywarren
Copy link
Member

It looks great but I think we can make a folder like /doc/images/ - how's that sound? Thanks!!!

sagarpreet-chadha
sagarpreet-chadha approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change by @jywarren and then looks good to go 😄 !

@stefannibrasil
Copy link
Author

@sagarpreet-chadha @jywarren yep, that makes more sense! folders updated, thanks for the help!

@milaaraujo milaaraujo self-assigned this Jul 17, 2018
@jywarren jywarren merged commit 362e178 into publiclab:master Jul 17, 2018
@ghost ghost removed the in progress label Jul 17, 2018
@jywarren
Copy link
Member

Awesome, thank you!!!

@stefannibrasil stefannibrasil deleted the add-codeclimate-doc branch July 20, 2018 01:03
@stefannibrasil stefannibrasil mentioned this pull request Jul 24, 2018
Closed
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@jywarren
Add CodeClimate documentation (publiclab#3068)
acb4311 
* CodeClimate documentation

* Changing image: doc/images/code_climate.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarpreet-chadha sagarpreet-chadha sagarpreet-chadha approved these changes

Assignees

@milaaraujo milaaraujo

@stefannibrasil stefannibrasil

Labels
rgsoc Rails Girls Summer of Code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefannibrasil @plotsbot @jywarren @sagarpreet-chadha @milaaraujo