migration for changing status of comments

[grvsachdeva]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[plotsbot]

	2 Warnings
⚠️	New migrations added. Please update schema.rb.example by overwriting it with a copy of the up-to-date db/schema.rb. Also, be aware to preserve the MySQL-specific conditions for full-text indices.
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	1 Message
📖	@Gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[siaw23-retired]

what's this related to? Can't understand the context.

[grvsachdeva]

Some time before we made a migration for setting default column value as 1 for comment, in that PR statement for changing previous comment status are also included but that doesn't work. So, right now in production DB, there is a mix of comments with status =1 and 0. For the implementation of Spam moderation system, it's required that all comments should carry status 1, otherwise many comments would become invisible. @siaw23 do you think this migration would work?

[grvsachdeva]

@jywarren please review this. Thanks!

[jywarren]

Excellent. Thanks!

[grvsachdeva]

@jywarren could you please check the DB for comment status so that #2957 can be merged. Thanks!

[jywarren]

I just got in the console:

Comment.where(status: 0).count

=> 0

…

On Tue, Jul 10, 2018 at 4:42 PM Gaurav Sachdeva ***@***.***> wrote: @jywarren <https://github.com/jywarren> could you please check the DB for comment status so that #2957 <#2957> can be merged. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3006 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_vdK6eKddVG2lm93Q1F3wBe2Xbiks5uFRGjgaJpZM4VGQfA> .