Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Like with emoji #2869

Merged
merged 6 commits into from
Jun 20, 2018
Merged

Like with emoji #2869

merged 6 commits into from
Jun 20, 2018

Conversation

ViditChitkara
Copy link
Member

@ViditChitkara ViditChitkara commented Jun 20, 2018 •
edited by jywarren
Loading

closes #2822
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned ViditChitkara Jun 20, 2018
@ghost ghost added the in progress label Jun 20, 2018
@ViditChitkara
Copy link
Member Author

emoji-like-3

@plotsbot
Copy link
Collaborator

plotsbot commented Jun 20, 2018 •
edited
Loading

1 Warning
⚠️ New migrations added. Please update schema.rb.example by overwriting it with a copy of the up-to-date db/schema.rb. Also, be aware to preserve the MySQL-specific conditions for full-text indices.
1 Message
📖 @ViditChitkara Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Ah, can you rebase, sorry! This looks AMAZING!!!

!

@jywarren
Copy link
Member

And, anything you want to tweak from CodeClimate suggestions, or just approve it?

@ViditChitkara
Copy link
Member Author

Done with the code climate fixes

@jywarren
Copy link
Member

Looking great! Ready to go? 😄

@ViditChitkara
Copy link
Member Author

Yes!!

@jywarren jywarren merged commit 75838b1 into publiclab:master Jun 20, 2018
@ghost ghost removed the in progress label Jun 20, 2018
@jywarren
Copy link
Member

So excited!!!

@ViditChitkara
Copy link
Member Author

Me too!!

@jywarren
Copy link
Member

screen shot 2018-06-20 at 6 33 29 pm

@jywarren
Copy link
Member

on staging! we hope to publish tomorrow 😄

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@ViditChitkara @jywarren
Like with emoji (publiclab#2869)
5697f0b 
* added emoji type to likes

* like via emoji feature initial

* code cleanup

* minor tweaks

* code climate fixes

* remove previous version of like-comment
@noi5e noi5e mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ViditChitkara ViditChitkara

Labels
summer-of-code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to "like" comments with an emoji
3 participants
@ViditChitkara @plotsbot @jywarren