Updating comment options order - Fixes Issue #2833 #2836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Neidley
commented
Jun 16, 2018
This was referenced Jun 17, 2018
Generated by 🚫 Danger |
grvsachdeva
reviewed
Jun 17, 2018
| @@ -114,7 +114,7 @@ GEM | |||
| activerecord (>= 4.0.0) | |||
| gemoji (3.0.0) | |||
There was a problem hiding this comment.
this file need to be excluded!
grvsachdeva
reviewed
Jun 17, 2018
| <%= link_to new_user_session_path( return_to: request.path ), style: "text-decoration: none; color: black;" do %> | ||
| <span class="fa fa-star-o"></span> | ||
| <span><%= comment.likers.count %></span> | ||
| <% end %> |
grvsachdeva
reviewed
Jun 17, 2018
| @@ -0,0 +1,6 @@ | |||
| version:2 | |||
| handle:{HMAC-SHA1}{5b259d93}{TgWPDA==} | |||
| secret:QmiQg8McY3Z95zIZvXEBtPl23A0= | |||
There was a problem hiding this comment.
this file is also not needed
grvsachdeva
reviewed
Jun 17, 2018
| @@ -0,0 +1,6 @@ | |||
| version:2 | |||
There was a problem hiding this comment.
Thanks for all your help and for my first PR 👍
|
Oh, oops! There's no need to close this PR if you're still working on it - you can keep adding commits and we'll be here to help out. I'll re-open it unless there's a new place you're working? Thanks for your help! |
|
Oh, ok! Oops! I see this is now over at #2834 (comment) Closing again! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.