Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added opening messages to questions/activites/replication pages #2830

Closed
wants to merge 2 commits into from

Conversation

rtrunkhill
Copy link
Contributor

Fixes issue 2520

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [ x] code is in uniquely-named feature branch and has no merge conflicts
  • [x ] PR is descriptively titled
  • [ x] PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Jun 14, 2018

1 Error
🚫 There was an error with Danger bot’s Junit parsing: undefined method `value’ for nil:NilClass
2 Messages
📖 @rtrunkhill Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren
Copy link
Member

This looks good - just to double check, would you mind posting some screenshots to show each version, with the URL shown too?

Thank you!!!

@jywarren
Copy link
Member

Oh wait, i see this is identical to #2831 -- i'm going to close this one so we just have one.

@jywarren jywarren closed this Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants