-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining gems added #2686
Remaining gems added #2686
Conversation
I will try to send one more pr for the can_tag implementation in the user_tag controller before my end sems ends. |
Generated by 🚫 Danger |
Good luck on your end sem exams!! If I could get a review from @publiclab/reviewers I'd love to merge this in -- thanks, all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me !
gem 'omniauth-google-oauth2' | ||
gem 'omniauth-twitter' | ||
gem 'omniauth-github', '~> 1.1', '>= 1.1.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SidharthBansal , could you point to Planning issue of your project ?
Awesome!!!! Thanks both of you!!! |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!