Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Wiki controller using User's new methods to check users' … #2532

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Refactor Wiki controller using User's new methods to check users' … #2532

merged 2 commits into from
Mar 23, 2018

Conversation

seafr
Copy link
Member

@seafr seafr commented Mar 23, 2018

…roles (see PR #2448)

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled

Thanks!

@PublicLabBot
Copy link

PublicLabBot commented Mar 23, 2018 •
edited
Loading

1 Message
📖 @seafr Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@seafr seafr requested a review from a team March 23, 2018 15:10
SidharthBansal
SidharthBansal approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb

@seafr seafr added review-me and removed ready labels Mar 23, 2018
sagarpreet-chadha
sagarpreet-chadha approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow !! This makes the code more readable , especially for First-Timers :) Thanks !

@seafr seafr added ready and removed review-me labels Mar 23, 2018
@seafr
Copy link
Member Author

seafr commented Mar 23, 2018

@SidharthBansal sorry, I removed the 'ready' label you added by mistake. I've just added it back. Thank you.
Thank you @sagarpreet-chadha

@jywarren
Copy link
Member

❤️

@jywarren jywarren merged commit 7658c35 into publiclab:master Mar 23, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@seafr @jywarren
Refactor Wiki controller using User's new methods to check users' … (p…
71bbcea 
…ubliclab#2532)

* Refactor Wiki controller using User's new methods to check users' roles (see publiclab#2448)

* "Fix punctuation" by removing the '\!'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarpreet-chadha sagarpreet-chadha sagarpreet-chadha approved these changes

@SidharthBansal SidharthBansal SidharthBansal approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seafr @PublicLabBot @jywarren @sagarpreet-chadha @SidharthBansal