Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of Notes controller, using User's new methods to check … #2522

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Refactor of Notes controller, using User's new methods to check … #2522

merged 1 commit into from
Mar 22, 2018

Conversation

seafr
Copy link
Member

@seafr seafr commented Mar 21, 2018

…users' roles (see #2448)

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled

@seafr seafr requested a review from grvsachdeva March 21, 2018 19:35
@PublicLabBot
Copy link

1 Message
📖 @seafr Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

SidharthBansal
SidharthBansal approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!

@jywarren jywarren merged commit f310664 into publiclab:master Mar 22, 2018
@jywarren
Copy link
Member

Awesome folks!!!!!!!!!

@seafr
Copy link
Member Author

seafr commented Mar 22, 2018

Thank you @SidharthBansal @jywarren 👍

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@seafr @jywarren
Refactor of Notes controller, using User's new methods to check users…
158f32b 
…' roles (see publiclab#2448) (publiclab#2522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SidharthBansal SidharthBansal SidharthBansal approved these changes

@grvsachdeva grvsachdeva Awaiting requested review from grvsachdeva

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seafr @PublicLabBot @jywarren @SidharthBansal