Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 2310 first time commit #2363

Closed
wants to merge 1 commit into from
Closed

Conversation

milindra
Copy link

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@PublicLabBot
Copy link

3 Messages
📖 @milindra Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please change the title to something more descriptive

  2. Please add a link to the original issue in the PR body

  3. Please don't commit any changes to Gemfile.lock

Thanks for your hard work and patience.

Copy link

@MayankKashyap MayankKashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @milindra please remember all things that ryzokuken said

@seafr
Copy link
Member

seafr commented Feb 18, 2018

#2310 has already been claimed by @jsmayo.
@milindra please find another issue to claim here. Looking forward to your first contribution.
@ryzokuken @MayankKashyap

@seafr
Copy link
Member

seafr commented Feb 26, 2018

@jywarren this is a duplicate PR and it should be closed. See #2362, which has already been merged.

@jywarren
Copy link
Member

Hi, @milindra -- thanks so much for your contribution. As the others have mentioned, this issue has already been solved, but we would love to help you make your first contribution -- maybe we can help you find one?

I'm going to close this now but will make one you can try out instead.

@jywarren jywarren closed this Feb 26, 2018
@jywarren
Copy link
Member

#2404 -- give this one a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants