-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 2310 first time commit #2363
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Please change the title to something more descriptive
-
Please add a link to the original issue in the PR body
-
Please don't commit any changes to
Gemfile.lock
Thanks for your hard work and patience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah @milindra please remember all things that ryzokuken said
#2310 has already been claimed by @jsmayo. |
Hi, @milindra -- thanks so much for your contribution. As the others have mentioned, this issue has already been solved, but we would love to help you make your first contribution -- maybe we can help you find one? I'm going to close this now but will make one you can try out instead. |
#2404 -- give this one a try! |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!