Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding of toolbar in comments #5013

Closed
5 tasks
IshaGupta18 opened this issue Mar 11, 2019 · 4 comments
Closed
5 tasks

Fix padding of toolbar in comments #5013

IshaGupta18 opened this issue Mar 11, 2019 · 4 comments
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML

Comments

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Mar 11, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/notes/_comment.html.erb in the plots2 repo and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red which lines to remove, and in green which lines to add:

- <div class="navbar-text navbar-right pull-right" style="padding-right:10px;">
+ <div class="navbar-text navbar-right pull-right" style="padding-right:20px;">

This will fix this:

image

To this:

image

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@IshaGupta18 IshaGupta18 added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Mar 11, 2019
@divyabaid16
Copy link
Contributor

Should I proceed with this issue?

@grvsachdeva
Copy link
Member

Hey @divyabaid16, this issue is for first-timers who haven't contributed to our codebase before so you can't do this one. But, we would love to have your help on other issues. Thanks!

@grvsachdeva
Copy link
Member

Actually @IshaGupta18, this issue is a duplicate of #4991 so closing this but I would refer the first-time contributor to your code if they face difficulty in solving the issue. Thanks!

@IshaGupta18
Copy link
Collaborator Author

Yes @divyabaid16 do help out in other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML
Projects
None yet
Development

No branches or pull requests

3 participants