Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Color Of Github Icons #3034

Closed
dewanhimanshu opened this issue Jul 10, 2018 · 5 comments
Closed

Change Color Of Github Icons #3034

dewanhimanshu opened this issue Jul 10, 2018 · 5 comments
Milestone
Login/SignUp & OAuth

Comments

@dewanhimanshu
Copy link
Collaborator

screenshot from 2018-07-10 23-26-34
the github icon is green every where . We should change its color to black son that it is more relevant.
@jywarren @SidharthBansal
@welcome
Copy link

welcome bot commented Jul 10, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄

@SidharthBansal
Copy link
Member

Four pages are to be considered
Login page
Header
Sign up page
Edit profile page
@jywarren what will you suggest?
I prefer black

@jywarren
Copy link
Member

jywarren commented Jul 10, 2018 via email

@SidharthBansal
Copy link
Member

@dewanhimanshu take care that all the four pages looks great after you have set them in a partial.
At some places we place the icons in the center while at other places we keep it on the left.

@SidharthBansal SidharthBansal added this to the OAuth Login milestone Jul 10, 2018
jywarren pushed a commit that referenced this issue Jul 12, 2018
@dewanhimanshu @jywarren
changed color of github icon and refactored code #3034 (#3050)
5373199 
* changed color of github icon and refactored code

* Update _comment.html.erb (#3048)

* changed icons styles

* changed env back

* some fixes

* all icons width set same

* fix

* added back env

* some fix

* Update API.md

* center align the text

* center align and added or

* added back env

* added spacing in or

* added env back

* errors on signup page (#3044)

* Update .travis.yml

* Swap the providers and email-password login (#3021)

* Change Login page & remove Gemfile.lock from PR

* Add Rails production environment check back in

* Uid visible to admin and account holder (#3039)

* Uid visible to admin and account holder

* few changes

* .

* minor tweaks

* test rectified

* ..

* test rectified

* Fallback email and welcome email with Oauth  (#3052)

* fallback welcome email

* sending welcome mail in oauth

* test

* added back env

* fixes

* removed extra spaves
@SidharthBansal
Copy link
Member

Completed.

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
@dewanhimanshu @jywarren
changed color of github icon and refactored code publiclab#3034 (publ…
ec84692 
…iclab#3050)

* changed color of github icon and refactored code

* Update _comment.html.erb (publiclab#3048)

* changed icons styles

* changed env back

* some fixes

* all icons width set same

* fix

* added back env

* some fix

* Update API.md

* center align the text

* center align and added or

* added back env

* added spacing in or

* added env back

* errors on signup page (publiclab#3044)

* Update .travis.yml

* Swap the providers and email-password login (publiclab#3021)

* Change Login page & remove Gemfile.lock from PR

* Add Rails production environment check back in

* Uid visible to admin and account holder (publiclab#3039)

* Uid visible to admin and account holder

* few changes

* .

* minor tweaks

* test rectified

* ..

* test rectified

* Fallback email and welcome email with Oauth  (publiclab#3052)

* fallback welcome email

* sending welcome mail in oauth

* test

* added back env

* fixes

* removed extra spaves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Login/SignUp & OAuth
Development

No branches or pull requests
3 participants
@jywarren @SidharthBansal @dewanhimanshu