Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki missing route for update #2802

Closed
icarito opened this issue Jun 9, 2018 · 7 comments
Closed

Wiki missing route for update #2802

icarito opened this issue Jun 9, 2018 · 7 comments
Assignees
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed

Comments

@icarito
Copy link
Member

icarito commented Jun 9, 2018

After rails 5 deployment wiki was not able to update.

To reproduce:
https://publiclab.org/w/sandbox-2
edit
try to save

[4a915bc2-682e-4ed5-8b86-a7ed91aa02b0] Started POST "/wiki/update/15029" for 190.42.17.93 at 2018-06-09 00:22:06 +0000
[4a915bc2-682e-4ed5-8b86-a7ed91aa02b0]
[4a915bc2-682e-4ed5-8b86-a7ed91aa02b0] ActionController::RoutingError (No route matches [POST] "/wiki/update/15029"):
[4a915bc2-682e-4ed5-8b86-a7ed91aa02b0]

You'll get a 404

@icarito icarito added bug the issue is regarding one of our programs which faces problems when a certain task is executed high-priority labels Jun 9, 2018
@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

Oh sorry second issue.

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

Moved second issue to #2803

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

Ugh, you'd imagine this'd be caught by:

post :update, params: { id: wiki.nid, uid: users(:bob).id, title: newtitle, body: 'Editing about Page' }

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

Ugh, you'd imagine this'd be caught by

post :update, params: { id: wiki.nid, uid: users(:bob).id, title: newtitle, body: 'Editing about Page' }

however i don't think functional tests go through routes at all! Not very useful... tests leading to a lot of redundancy!

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

OK, added an integration test for this and solving...

@ghost ghost removed the in progress label Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed
Projects
None yet
Development

No branches or pull requests

2 participants