Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "search by topic" to top of page and remove sidebar on /questions #2333

Closed
jywarren opened this issue Feb 15, 2018 · 2 comments
Closed
Labels
enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML

Comments

@jywarren
Copy link
Member

jywarren commented Feb 15, 2018

(via @ebarry) This is a two-part issue -- on http://publiclab.org/questions, we have a sidebar area called Filter questions by topic which we'd like to move to a 2-column area in the main column, next to the "Ask a question" area.

The code for the form to be moved is here:

<% if params[:controller] == 'questions' %>
<%= render partial: 'tag/sorting' %>
<% end %>

We can move the form into a col-md-6 div using Bootstrap's grid system: https://getbootstrap.com/docs/3.3/css/#grid-options -- so,


Then we'd like to delete the sidebar entirely, by deleting this line:

<%= render :partial => "sidebar/user" %>

We should then change the main area to be full-with, so 9 becomes 12 on this line:

<div class="col-md-9">

The new side-by-side forms could use some text tweaking too:

  • The "filter" one we're moving could be titled: View questions by topic, with placeholder input text type your topic and button text Search
  • The original area could become Ask a question here with placeholder text type your question and button text Continue

The new two-column area may need some design tweaking to get it right, so if you're able to take on this issue, please post a screenshot with your pull request! Thank you!

@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML labels Feb 15, 2018
@jywarren jywarren added this to the UI and newcomer onboarding milestone Feb 15, 2018
@stefannibrasil
Copy link

I am taking this one too @jywarren

@jywarren
Copy link
Member Author

jywarren commented Feb 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML
Projects
None yet
Development

No branches or pull requests

2 participants