Add glyphicons to notes page

[SidharthBansal]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Please describe the problem

Some of the tabs on /notes/popular are not having glyphicons. Add the required glyphicons

Solution

Relevant view file that need change is

plots2/app/views/notes/index.html.erb

Lines 29 to 33 in 57f0d6f

	<li<% if params[:action] == "index" %> class="active"<% end %>><a href="/notes/"><%= t('notes.index.recent') %></a></li>
	<li<% if params[:action] == "popular" %> class="active"<% end %>><a href="/notes/popular/"><%= t('notes.index.popular') %></a></li>
	<li<% if params[:action] == "liked" %> class="active"<% end %>><a href="/notes/liked/"><i class="fa fa-star-o"></i><span class="hidden-sm"> <%= t('notes.index.liked') %></span></a></li>
	<li><a href="/wiki/"><%= raw t('notes.index.wiki_pages') %></a></li>

Refer https://www.w3schools.com/icons/bootstrap_icons_glyphicons.asp or similar sites
📋 Step by Step

🙋‍♀️ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💾 Commit your changes

🔀 Start a Pull Request.

🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

[AndyCodez]

I'd like to work on this.

[grvsachdeva]

That's great @AndyCodez, please start.