Share buttons not aligned

[grvsachdeva]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Please describe the problem

Notes page shows un-aligned Twitter and Fb buttons.Example: https://publiclab.org/notes/programmer1200/02-03-2018/photometer-kit-idea

Solution

Change CSS of the buttons so as to align them.Relevant view file that need change is https://github.com/publiclab/plots2/app/views/home/_social.html.erb

📋 Step by Step

🙋‍♀️ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💾 Commit your changes

🔀 Start a Pull Request.

🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

[BigFun76]

Has this been resolved?

[James-N-M]

I’ll claim this as well ! Since you tagged in it earlier

[ViditChitkara]

@BigFun76 , no this isn't resolved yet
Either one of you could resolve it!!

[BigFun76]

OK. First-timer here. Still trying to figure out how it all works. Thanks.

[ViditChitkara]

Cool, you could look into the file mentioned by @Gauravano for fixing the bug.

[BigFun76]

I will, thanks. On my phone now, but should be on the laptop soon.

[Shadlimitless]

Has this issue been closed? First timer here

[ViditChitkara]

Hey @Shadlimitless!! No, this is still open. @BigFun76 is working on it! There are lots of first timer issues available! You may work on any one of them! 👍

[BigFun76]

Sorry everyone, I figured out how to clone this to my laptop and edit the file. However, I do not know how to run it to see if the changes work. I don't have any experience with Ruby and have tried just opening it as an html file, but am not sure if that will be correct. Hard to tell if I am headed in the right direction, if I can't see my changes.

[grvsachdeva]

Hi @BigFun76, you can follow installation steps https://github.com/publiclab/plots2#installation and if you still face any issue regarding running, we would surely help you.

[BigFun76]

Thanks

[BigFun76]

OK, I have submitted a PR. Not sure if it is exactly what you were wanting. At least I now understand the process a little better. Next step is being better with the actual code.

Thanks again everyone!

[Shadlimitless]

@ViditChitkara thanks ! Let me look for another open issue :-)

[BigFun76]

I will need to let someone else handle this issue. I am in over my head on some of the logistics for Ruby, etc. and don’t know when I’ll have time to sort through them. Sorry everyone.

[Shadlimitless]

Id like to pick this up, following the instructions on cloning from @Gauravano

[ViditChitkara]

@Shadlimitless cool, go ahead!
No worries @BigFun76 you could ping us if you need any kind of help!

[grvsachdeva]

hi @Shadlimitless , this issue is resolved in #2329 , you can find new issues at https://publiclab.github.io/community-toolbox/#r=all .Thanks.