Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink text #2191

Closed
SidharthBansal opened this issue Feb 1, 2018 · 2 comments
Closed

Hyperlink text #2191

SidharthBansal opened this issue Feb 1, 2018 · 2 comments
Assignees

Comments

@SidharthBansal
Copy link
Member

Please describe the problem (or idea)

image
This the text next to the hyperlink button which is not needed as the functionality is present in the hyperlink button itself

Please show us where to look

/wiki/:id
https://publiclab.org/wiki/authoring-help

@jywarren
Copy link
Member

jywarren commented Feb 2, 2018

Hi, you know, I like the idea of simplifying here, but I actually also like the actual number appearing so you can see what the ID is on a quick glance. I sometimes copy paste that number! Maybe we could modify this PR so it shows #1234 instead of /n/1234, though, so people can copy paste and use them as references as we do in Github, like #2192 -- what do you think?

@SidharthBansal SidharthBansal changed the title Hyperlink text not needed Hyperlink text Feb 2, 2018
@SidharthBansal
Copy link
Member Author

Yeah, you are right. We may need it. Actually /n/1234 made me ambiguous until I saw the code. So thought it will create much more ambiguity to the user of public lab so removed it.
I have changed it to #1234 syntax. It will not create ambiguity. Please review my pr @jywarren
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants