Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 #823

Closed
wants to merge 121 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
121 commits
Select commit Hold shift + click to select a range
20c81a2
ActiveSupport::Testing::Performance extracted to a gem
cesswairimu May 5, 2019
d4131fd
ruby prof required as a dependency
cesswairimu May 5, 2019
9c21952
Configurations update for rails 4.0
cesswairimu May 5, 2019
c4a3cba
disable rubocop on bin folder
cesswairimu May 5, 2019
58b80a1
http patch
cesswairimu May 5, 2019
76d6e33
Comment out to allow testing
cesswairimu May 5, 2019
3d7d8ba
no longer supports plugin loading
cesswairimu May 5, 2019
8b2eaaf
lock to sprockets 2.12
cesswairimu May 5, 2019
ddb6d7c
Active record patches
cesswairimu May 5, 2019
a79930a
remove deprecated test syntax
cesswairimu May 6, 2019
a1d0aaf
fix failing tests
cesswairimu May 7, 2019
7cb7a4d
change new super class
cesswairimu May 7, 2019
2ef8715
replace right_aws with right_aws_api
cesswairimu May 9, 2019
fc838a8
lock to rails 4.2.11.1
cesswairimu May 14, 2019
b5b6340
change rails version in install script
cesswairimu May 14, 2019
6dc3a69
remove deprecation warnings
cesswairimu May 14, 2019
06f4d00
make app work
cesswairimu May 14, 2019
4db8646
Change test lib to minitest, add minitest reporters
cesswairimu May 11, 2019
6ddb5bc
active record find patches
cesswairimu May 15, 2019
4f31616
root_in_json include defaulted to false
cesswairimu May 16, 2019
76e078a
confirm option removed in link helper
cesswairimu May 16, 2019
5d613e8
cookies serializer changed to hybrid
cesswairimu May 16, 2019
80e12b7
Change render :text to :plain
cesswairimu May 16, 2019
01d86fa
console for dev web
cesswairimu May 16, 2019
db6c5fa
Check and fix interface functionality
cesswairimu May 18, 2019
290273f
fix export functionality
cesswairimu May 21, 2019
36c9208
add protected attributes for the warpable model
cesswairimu May 28, 2019
c53bf27
fix image upload
cesswairimu May 31, 2019
2f23252
Fix comments and images failing tests
cesswairimu Jun 1, 2019
0f76698
include mass assignment security in annotations
cesswairimu Jun 4, 2019
de27727
render html for update images
cesswairimu Jun 4, 2019
685143c
clear mail array before every test
cesswairimu Jun 4, 2019
74a9ecb
Fix codeclimate issues
cesswairimu Jun 5, 2019
daac614
skip failing test
cesswairimu Jun 7, 2019
528ec09
replace unprotected redirects
cesswairimu Jun 7, 2019
1d220ec
Fix codeclimate issues
cesswairimu Jun 5, 2019
5bb19c2
Autofixing rubocop offenses and Problematic test for #578 (#667)
alaxalves Jun 6, 2019
11dd71f
change post test to create since action new is a get action
cesswairimu Jun 7, 2019
fbb29ba
remove unprotected redirects
cesswairimu Jun 7, 2019
bba8fad
Fix codeclimate issues
cesswairimu Jun 7, 2019
6bc9a8c
Add yarn
kaustubh-nair Jun 10, 2019
116f385
Remove error log
kaustubh-nair Jun 10, 2019
75c2fef
Fix oauth icons
kaustubh-nair Jun 10, 2019
1f1dedd
Modify package.json
kaustubh-nair Jun 10, 2019
f7f526f
Add yarn install to start.sh
kaustubh-nair Jun 10, 2019
68385c3
Add leaflet google
kaustubh-nair Jun 10, 2019
ae88815
Remove leaflet-google from package json
kaustubh-nair Jun 10, 2019
49af138
remove passenger error logs
kaustubh-nair Jun 10, 2019
b34dd84
Fix install script
kaustubh-nair Jun 10, 2019
5c0c7c7
Remove flag
kaustubh-nair Jun 11, 2019
22e5312
Fix gemfile.lock
kaustubh-nair Jun 11, 2019
5da06ce
Fix gemfile.lock
kaustubh-nair Jun 11, 2019
2ecc4be
Merge branch 'yarn-bower' into development
kaustubh-nair Jun 11, 2019
d71d9ad
Fix login
kaustubh-nair Jun 11, 2019
1d1211f
Upgrade Gemfile to Rails 5.0
kaustubh-nair Jun 12, 2019
13cdef5
require rake'
kaustubh-nair Jun 12, 2019
c20a903
Change config files
kaustubh-nair Jun 12, 2019
5a28772
Add application record
kaustubh-nair Jun 12, 2019
df7b02f
Bump mysql
kaustubh-nair Jun 12, 2019
1c1e2c2
Local builds for Travis runners (#672)
alaxalves Jun 13, 2019
3385812
Merge branch 'development' of https://github.com/publiclab/mapknitter…
alaxalves Jun 13, 2019
4cd47a4
Test yarn for travis
kaustubh-nair Jun 13, 2019
f0297dd
Conditionalize rake db:setup for travis
kaustubh-nair Jun 13, 2019
40ad993
Add semicolon
kaustubh-nair Jun 13, 2019
91d082f
Remove comment
kaustubh-nair Jun 13, 2019
0607a4f
modify database.yml
kaustubh-nair Jun 13, 2019
a3e7ff8
Migrate seperately
kaustubh-nair Jun 13, 2019
525eb1a
Run create only for production
kaustubh-nair Jun 13, 2019
4fb5be3
Locking newer Rails v
alaxalves Jun 13, 2019
d058ce3
Running update task
alaxalves Jun 13, 2019
d90db0e
Adding missing bootsnap gem
alaxalves Jun 13, 2019
6e28143
Merge branch 'development' of https://github.com/publiclab/mapknitter…
alaxalves Jun 13, 2019
6545537
Fixing missing database
alaxalves Jun 13, 2019
24bd1f7
Adding missing listen gem
alaxalves Jun 13, 2019
e60bb83
Fixing schema example version
alaxalves Jun 13, 2019
6bedcc1
Fixing migration versions
alaxalves Jun 13, 2019
642beb4
Fix conflicts
kaustubh-nair Jun 16, 2019
2c746c1
Updating dependencies for Rails 5
alaxalves Jun 19, 2019
88b3c8a
Adding ApplicationMailer abstraction
alaxalves Jun 19, 2019
17f8e88
Adding required initializers
alaxalves Jun 19, 2019
463fd8d
Prefer require_relative instead of full path
alaxalves Jun 19, 2019
154f8b5
Making associations not required by default
alaxalves Jun 19, 2019
c9e8b1b
Merge branch 'development' of https://github.com/publiclab/mapknitter…
alaxalves Jun 19, 2019
bccec1b
Regenerating schema file
alaxalves Jun 19, 2019
f678d95
Hotfixing MassAssigment
alaxalves Jun 19, 2019
f39d468
Upgrade web-console, remove mysql adapter override
kaustubh-nair Jun 20, 2019
c1837f1
Remove attr_accessible
kaustubh-nair Jun 20, 2019
cfca3ce
Add rails-controller-testing gem
kaustubh-nair Jun 20, 2019
47ce35a
Follow new syntax for tests
kaustubh-nair Jun 20, 2019
10cec89
Fix conflicts
kaustubh-nair Jun 20, 2019
ca9a118
Remove extra web-console from gemfile
kaustubh-nair Jun 20, 2019
d86282c
Regenerating lock file
alaxalves Jun 21, 2019
616f1fe
Fixing rubocop offenses and bundler version
alaxalves Jun 21, 2019
2495a8a
Using correct Paperclip class as in https://github.com/rails/rails/is…
alaxalves Jun 21, 2019
b2fdaea
Fix images functional tests
kaustubh-nair Jun 25, 2019
03bcfd3
images controller test typecast to string
kaustubh-nair Jun 25, 2019
672fabd
Fix rails logger
kaustubh-nair Jun 25, 2019
a146edb
Fix map tests
kaustubh-nair Jun 25, 2019
3a10c73
Bumping rubocop version
alaxalves Jun 27, 2019
e2e17e5
Autofixing rubocop offenses
alaxalves Jun 27, 2019
1340e4d
Including performance cop to rubocop
alaxalves Jun 27, 2019
37efb69
Refactoring deprecated routing and secret_token
alaxalves Jun 27, 2019
d81e8e0
Fixing routes for feed controller
alaxalves Jun 27, 2019
87bb313
Using correct routes for RSS builder
alaxalves Jun 27, 2019
a5726c7
Fixing missing routes
alaxalves Jun 28, 2019
b0b1dc0
Fixing travis bundler and yarn cache
alaxalves Jun 28, 2019
6cfd543
Fixing bundle path
alaxalves Jun 28, 2019
4fa14f2
Splitting bundle and yarn verifications
alaxalves Jun 29, 2019
b40bebd
Merge branch 'main' of https://github.com/publiclab/mapknitter into d…
alaxalves Jul 2, 2019
d5ed24a
Autofixing rubocop offenses
alaxalves Jul 2, 2019
5db0ac9
Merge branch 'development' of https://github.com/publiclab/mapknitter…
alaxalves Jul 2, 2019
6cf32f7
Fixing prod host for travis, private class usage and rubocop offenses
alaxalves Jul 3, 2019
8512b65
Merge branch 'development' of https://github.com/publiclab/mapknitter…
alaxalves Jul 3, 2019
18436ae
Upgrade to Rails 5.2 (#685)
kaustubh-nair Jul 3, 2019
3f12c76
Merge branch 'rails-5' of https://github.com/publiclab/mapknitter int…
alaxalves Jul 3, 2019
e67ed3b
Merge branch 'main' of https://github.com/publiclab/mapknitter into d…
alaxalves Jul 3, 2019
297bcb0
Enforcing params usage on get method
alaxalves Jul 3, 2019
e3f3c9d
Using correct folder names to Rails >5 conventions
alaxalves Jul 3, 2019
3291e16
Merge branch 'main' of https://github.com/publiclab/mapknitter into d…
alaxalves Jul 6, 2019
553d8ea
Enforcing params wrapping and adding missing front_ui route
alaxalves Jul 6, 2019
dca3f90
Bumping rails version
alaxalves Jul 9, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,3 @@ todo.txt
coverage_report/
test/reports/*
yarn-error.log

2 changes: 2 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require: rubocop-performance

# Start with Spotifys style guide as a base then customize from there
inherit_from:
- .rubocop_shopify_styleguide.yml
Expand Down
38 changes: 23 additions & 15 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
language: ruby

rvm:
- 2.4.6

Expand All @@ -7,17 +8,25 @@ services:
- docker

cache:
bundler: true
directories:
- public/lib/
- $PWD/public/lib/
- $PWD/vendor/.bundle/

install:
- cp config/database.yml.example config/database.yml
- cp config/config.yml.example config/config.yml
- cp db/schema.rb.example db/schema.rb
- ./lib/exporter-deps.sh > /dev/null 2>&1
- bundle install && yarn install
- bundle exec rake db:setup || bundle exec rake db:migrate
- bundle check --path vendor/.bundle/ || bundle install --path vendor/.bundle/
- yarn check || yarn install
- if [ $RAILS_ENV == 'production' ]; then
mysql -e "CREATE DATABASE mapknitter;";
mysql -e "CREATE USER 'mapknitter'@'%' IDENTIFIED BY 'mapknitter';";
mysql -e "GRANT ALL PRIVILEGES ON *.* TO 'mapknitter'@'%';";
bundle exec rails db:schema:load;
else
bundle exec rails db:setup || bundle exec rails db:migrate;
fi

env:
global:
Expand All @@ -27,25 +36,24 @@ env:

jobs:
include:
- name: "Unit Tests"
script: bundle exec rake test:unit
- name: "Models Tests"
script: bundle exec rails test:models
- name: "Integration Tests"
script: bundle exec rake test:integration
- name: "Functional Tests"
script: bundle exec rake test:functional
script: bundle exec rails test:integration
- name: "Controllers Tests"
script: bundle exec rails test:controllers
- name: "Rubocop Linter"
script: bundle exec rubocop
- name: "Docker Builds"
script: docker build -t mapknitter .
# Configure this option after full yarn setup
# - name: "Asset Precompilation"
# env:
# - RAILS_ENV=production
# script: bundle exec rake assets:precompile
- name: "Asset Precompilation"
env:
- RAILS_ENV=production
script:
- bundle exec rails assets:precompile

branches:
only:
- main
- unstable
- development

66 changes: 37 additions & 29 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,80 +1,88 @@
source "https://rubygems.org"
source 'https://rubygems.org'

ruby '2.4.6'
gem 'rails', '4.2.11.1'
ruby '2.6.3'
gem 'rails', '~> 6.0.0.rc1'
gem 'rake', '~> 12.3.2'
gem 'tzinfo-data'
gem 'skylight'

gem "will_paginate", "3.1.7"
gem 'will_paginate-bootstrap4'
gem "friendly_id"
gem 'will_paginate', '3.1.7'
gem 'will_paginate-bootstrap4', '~> 0.2.2'
gem 'friendly_id'
gem 'popper_js', '~> 1.11', '>= 1.11.1'
gem 'protected_attributes'

# dependencies
group :dependencies do
gem 'mysql2', '< 0.4'
gem "geokit-rails", "1.1.4"
gem 'mysql2', '< 0.6'
gem 'geokit-rails', '1.1.4'
gem 'image_science', '1.3.0'
gem "recaptcha", :require => "recaptcha/rails"
gem "oa-openid", "0.3.2"
gem "ruby-openid", "~>2.5"
gem "open_id_authentication"
gem "RubyInline"
gem "paperclip", "~>4.3.7"
gem 'recaptcha', '~> 4.14.0', require: 'recaptcha/rails'
gem 'oa-openid', '0.3.2'
gem 'ruby-openid', '~>2.5'
gem 'open_id_authentication'
gem 'RubyInline', '~> 3.12.4'
gem 'paperclip', '~> 6.1.0'
gem 'bootsnap', '~> 1.4.4'
gem 'turbolinks', '~> 5'
gem 'mini_magick', '~> 4.8'

# if you use amazon s3 for warpable image storage
gem 'aws-sdk', '~> 1.5.7'

# for rake image migration tasks
# gem 'right_aws'
gem 'right_aws_api'
gem 'right_aws_api', '~> 0.3.5'

# compiling markdown to html
gem "rdiscount", "2.2.0.1"
gem 'rdiscount', '2.2.0.1'

# asset pipelining
gem 'bootstrap-sass'
gem 'sassc-rails'
gem 'jquery-rails'
gem "sprockets"
gem 'sprockets', '3.7.2'
gem "sprockets-rails"
gem "sass", :require => 'sass'
gem "autoprefixer-rails"
gem "uglifier"
gem 'sass', require: 'sass'
gem 'autoprefixer-rails', '~> 9.5.1.1'
gem 'uglifier', '~> 4.1.20'

end

group :test do
gem 'rubocop', '~> 0.52.0'
gem 'rubocop', '~> 0.70.0'
gem 'rubocop-performance'
gem 'ruby-prof'
gem 'rails-perftest'
gem 'rails-controller-testing'
gem 'simplecov', require: false
gem 'codecov', require: false
gem 'minitest'
gem 'minitest-reporters'
end

group :development, :test do
gem "byebug"
gem 'faker'
gem 'pry-rails'
gem 'byebug', '~> 11.0.1', platforms: [:mri, :mingw, :x64_mingw]
gem 'faker', '~> 1.9.3'
gem 'pry-rails', '~> 0.3.9'
end

group :development do
gem "jshintrb"
gem "therubyracer"
gem 'jshintrb', '~> 0.3.0'
gem 'mini_racer', platforms: :ruby
gem 'listen', '~> 3.1.5'
gem 'web-console', '~> 3.3'
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
end

group :sqlite do
# if you decide to use sqlite3 as the database
gem "sqlite3"
gem 'sqlite3'
end

group :passenger do
# passenger server
gem "passenger"
gem 'passenger'
end

gem 'httparty'
Loading