Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "maps by region" readable in JSON API #251 #266

Merged
merged 1 commit into from
May 29, 2018

Conversation

sagarpreet-chadha
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha commented May 25, 2018

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

Fixes #251 .

  • tests pass -- rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

@sagarpreet-chadha
Copy link
Contributor Author

@jywarren , @publiclab/reviewers ...kindly review this .

@jywarren jywarren merged commit 5b93f6a into publiclab:master May 29, 2018
@jywarren
Copy link
Member

Looks great!!! Merging!!!

@jywarren
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants