Change cursor to pointer

[divyabaid16]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update

Changes: Chance cursor to pointer download and pan to this image
Make changes in file app/views/images/_index.html.erb Change

mapknitter/app/views/images/_index.html.erb

Line 42 in dc96ada

<a rel="tooltip" id="locate-warpable-<%= warpable.id %>" title="Pan to this image" class="btn btn-sm btn-success"><i class='fa fa-crosshairs'></i></a>

mapknitter/app/views/images/_index.html.erb

Line 43 in dc96ada

<a rel="tooltip" title="Download full resolution distorted image (please allow popups)" class="btn btn-sm btn-outline-secondary img-download img-download-<%= warpable.id %>" data-image="/images/fetch/?url=<%= warpable.image.url(:original) %>"><i class="fa fa-download"></i></a>

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[SebastianLF]

Still open for first-timer? :)

[divyabaid16]

Yes @Zelol you can work on this.
Thanks!

[joreneng]

Hi, is this still open?

[divyabaid16]

@Zelol are you working on this?

[SebastianLF]

@divyabaid16 Oops I forgot. I will work on it immediately. Sorry again.

[divyabaid16]

Go ahead on solving this @Zelol
And we will create another issue for you @joreneng
Thanks!

[SebastianLF]

@divyabaid16 Seems that it requires various installation and I honestly do not have the time right now.
I cannot work on it this week, too. I'll leave my place to @joreneng. Sorry again.

[divyabaid16]

No problem @Zelol you can try some other time.
@joreneng would you like to work on this now?
Thanks!

[joreneng]

@divyabaid16 I'll work on it!

[metonymic-smokey]

Hey @divyabaid16 what's the status of this issue at present?
If no one else is working on it, I'd like to take it on as my first contribution to mapknitter!

[divyabaid16]

Since the user hasn't been active for more than a month, you can work on it. We would be glad to help you out.
Thanks!

[metonymic-smokey]

Cool!
Will get started. Currently trying to get the dev environment working on my system.

[metonymic-smokey]

@divyabaid16 I had a few small queries.
I'm working using the Codenvy environment for now.

1. I'm not able to locate the image you've linked in this answer. Where exactly is it located so I can re create this issue?
   2.If I understood right, I have to change to a pointer, with the already existing tooltip text, shown when the pointer hovers over this image?

[metonymic-smokey]

@divyabaid16 got the dev env running locally! Sorry for the delay.
Could you please clarify the above?
Thanks!

[divyabaid16]

Okay, so now, follow the instructions to go to the image tab:

1. Click on "Make a Map+" option that is present on the front page.
2. You will be redirected to a page where you can create the map. Add the title and the location.
3. The map corresponding to that location will open up. There, start by uploading an image. After you upload an image, you will get there 3 buttons. In that simply change the cursor to the pointer when the mouse hovers on them.

If I understood right, I have to change to a pointer, with the already existing tooltip text, shown when the pointer hovers over this image?

Yes!

[metonymic-smokey]

@divyabaid16 I've changed the cursor to pointer and made the commits on my fork.
I had to change _new.html.erb too along with _index.html.erb, since changing only _index.html.erb didn't change it to pointer.
Here are the screenshots:


2 other things:
a.The tooltip text appears to the left of the page for Download and Pan right from the beginning. Does this happen to other users too on their local systems?
b.The title of my image,being rather long, clashes with the buttons. Is there a limit on the no. of characters for a title or so to avoid this?
This is the first screenshot of MapKnitter:

So wanted to ask if these happen with other users on their local systems too.
If you're okay with this, I'll open a PR.
Thanks!

[divyabaid16]

These changes are great.
Firstly open a PR to change the cursor to a pointer.

The tooltip text appears to the left of the page for Download and Pan right from the beginning. Does this happen to other users too on their local systems?

For this, I have already made a PR #923 which solves this problem.

And for the last one,
You can create a separate issue and then create the PR for the same. I guess limiting is not a good option since while uploading we are not changing the name of the file and it has the same name as it is stored in the laptop. So rather, we can make the long name append down to the next line so that overlapping problem can be solved.
What are your views on this?

Thanks and welcome to Public Lab 🎈

[metonymic-smokey]

I'll create an issue about the second point @divyabaid16 .
I'll take some time to try and resolve the issue since I'm first exploring the codebase, etc. but I'll try my best to do it. I'll revert to the maintainers in case of any doubts.
In the meantime, I'll look for similar issues I could solve.

Thanks a lot!